-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for high keyframe interval, reduce log level for discovery loop #2709
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
===================================================
- Coverage 56.35194% 56.33265% -0.01929%
===================================================
Files 88 88
Lines 19128 19131 +3
===================================================
- Hits 10779 10777 -2
- Misses 7761 7765 +4
- Partials 588 589 +1
Continue to review full report at Codecov.
|
By default a B will timeout all segments received equal or greater than 8 seconds.
Works great, really needed to clean up the logs while using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this pull request do? Explain your changes. (required)
Specific updates (required)
Added logging to
SegmenterTimeout
error inmedia_server.go
to suggest for the broadcaster to lower their keyframe interval. Confirmed this error often occurs when the keyframe interval is 8 seconds or higher.RTMP Timeout: Ensure keyframe interval is less than 8 seconds
Reduced log level for orchestrator discovery loop during streaming to
debug
, this helps prevent excessive logging when broadcaster has only a few orchestrators. Example of issue: Broadcaster Discovery Loop Errors.txtHow did you test each of these updates (required)
-orchAddr
using low deposit.-v
flag. Confirmed discovery loop error logs will appear only if-v 5
or higher is used.Does this pull request close any open issues?
None
Checklist:
make
runs successfully./test.sh
pass