-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: Bump go and livepeer-data version #2804
Conversation
Type changed on livepeer-data version
The upgrade indirectly added a module that requires 1.19
8986d68
to
e4099ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
===================================================
+ Coverage 56.63383% 56.64361% +0.00978%
===================================================
Files 88 88
Lines 19084 19086 +2
===================================================
+ Hits 10808 10811 +3
+ Misses 7682 7681 -1
Partials 594 594
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional changes LGTM as well. Curious what was the fix for the protoc errors? Couldn't tell from the diff.
@victorges I didn't actually see any protoc errors, I think either it was a symptom of one of the things I fixed or something environmental |
Weird! I guess the last build I got the protoc error was this: https://github.com/livepeer/go-livepeer/actions/runs/5181242457/jobs/9336484395 Then I think I made some changes that apparently fixed it and organized the commit history and push forced and it started working somehow haha |
* go.mod: Update livepeer-data lib * server: Fix MetadataQueue type Type changed on livepeer-data version * go.mod: Bump go to 1.20 The upgrade indirectly added a module that requires 1.19 * changelog: Change changelog * Go 1.20 -> 1.20.4 * Get rid of go-version-file * Bump lint version * Set go version in another place * go fmt * Add glog goroutine to ignored leak ones * Change order of go mod command * Bump linter version --------- Co-authored-by: Thom Shutt <[email protected]>
What does this pull request do? Explain your changes. (required)
This bumps livepeer-data version and fixes the breaking changes after that. Ended up also
having to upgrade go version, otherwise the build of a transitive dependency started failing.
Unblocks go-livepeer to start using catalyst-api (which uses the later version of livepeer-data).
Specific updates (required)
How did you test each of these updates (required)
make
(I did the breaking change onlivepeer-data
myself and know it's only cosmetic)Does this pull request close any open issues?
Informal.
Checklist:
make
runs successfully./test.sh
pass