Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a floor of 1.5s for threshold to switch Os #2837

Merged
merged 3 commits into from
Aug 9, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/broadcast.go
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,12 @@ func selectSession(ctx context.Context, sessions []*BroadcastSession, exclude []
// durMult can be tuned by the caller to tighten/relax the maximum in flight time for the oldest segment
maxTimeInFlight := time.Duration(durMult) * oldestSegInFlight.segDur

// We're more lenient for segments <= 1s in length, since we've found the overheads to make this quite an aggressive target
// to consistently meet, so instead set a floor of 1.5s
if maxTimeInFlight <= 1*time.Second {
maxTimeInFlight = 1500 * time.Millisecond
}

if timeInFlight < maxTimeInFlight {
clog.PublicInfof(ctx,
"Selected orchestrator reason=%v",
Expand Down