Add Orch blocklist CLI param

CHANGELOG_PENDING.md

@@ -9,7 +9,8 @@
 #### General
 
 #### Broadcaster
-- \#2837 Set a floor of 1.5s for accepted Orchestrator response times, regardless of segment length (@thomshutt) 
+- \#2837 Set a floor of 1.5s for accepted Orchestrator response times, regardless of segment length (@thomshutt)
+- \#2839 Add Orchestrator blocklist CLI parameter (@mjh1)
 
 #### Orchestrator
 

cmd/livepeer/livepeer.go

@@ -123,6 +123,7 @@ func parseLivepeerConfig() starter.LivepeerConfig {
 	cfg.VerifierPath = flag.String("verifierPath", *cfg.VerifierPath, "Path to verifier shared volume")
 	cfg.LocalVerify = flag.Bool("localVerify", *cfg.LocalVerify, "Set to true to enable local verification i.e. pixel count and signature verification.")
 	cfg.HttpIngest = flag.Bool("httpIngest", *cfg.HttpIngest, "Set to true to enable HTTP ingest")
+	cfg.OrchBlacklist = flag.String("orchBlocklist", "", "Comma-separated list of blocklisted orchestrators")
 
 	// Transcoding:
 	cfg.Orchestrator = flag.Bool("orchestrator", *cfg.Orchestrator, "Set to true to be an orchestrator")

cmd/livepeer/starter/starter.go

@@ -1263,7 +1263,7 @@ func parseOrchBlacklist(b *string) []string {
 	if b == nil {
 		return []string{}
 	}
-	return strings.Split(*b, ",")
+	return strings.Split(strings.ToLower(*b), ",")
 }
 
 func validateURL(u string) (*url.URL, error) {

discovery/discovery.go

@@ -83,7 +83,7 @@ func (o *orchestratorPool) GetOrchestrators(ctx context.Context, numOrchestrator
 
 	isBlacklisted := func(info *net.OrchestratorInfo) bool {
 		for _, blacklisted := range o.orchBlacklist {
-			if strings.TrimPrefix(blacklisted, "0x") == hex.EncodeToString(info.Address) {
+			if strings.TrimPrefix(blacklisted, "0x") == strings.ToLower(hex.EncodeToString(info.Address)) {
 				return true
 			}
 		}