-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ports to be different for B / O / T #2850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, but I see that e2e tests are failing.
E0831 13:58:06.488086 20826 gaspricemonitor.go:122] error getting gas price: Post "http://172.17.0.1:32779/": read tcp 172.18.0.2:39278->172.17.0.1:32779: read: connection reset by peer
E0831 13:58:06.661925 20826 webserver.go:22] http: Server closed
FAIL
FAIL github.com/livepeer/go-livepeer/test/e2e 326.824s
FAIL
Error: Process completed with exit code 1.
Could you please check?
Can you try re-running the test? I think the one that is failing is one of the problem tests. The tests pass on my test run but had to run twice. https://github.com/ad-astra-video/go-livepeer/actions/runs/6084402253 |
Yeah, that's possible. I think that you need to resolve the conflicts and then when you push the build should pass. |
These conflicts are the changes I made for the ports right? Am I missing something? |
fdcb4fc
to
08d9519
Compare
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
===================================================
- Coverage 56.70668% 56.50185% -0.20483%
===================================================
Files 88 88
Lines 19160 19233 +73
===================================================
+ Hits 10865 10867 +2
- Misses 7699 7767 +68
- Partials 596 599 +3
Continue to review full report in Codecov by Sentry.
|
Good work, this will make running the full stack much easier on a single machine. |
Thank you @ad-astra-video this works nicely! |
What does this pull request do? Explain your changes. (required)
Updates ports as suggested in #2797
@chrishobcroft
Specific updates (required)
starter.go
to use separate portsHow did you test each of these updates (required)
starter.go
tests passedDoes this pull request close any open issues?
See above.
Checklist:
make
runs successfully./test.sh
pass I think the test that is failing is not caused by this update but please confirm.