ci: add protoc on build #2899
Open
ci: add protoc on build #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
approved these changes
Oct 25, 2023
iameli
force-pushed
the
eli/protoc-on-build
branch
from
57df927 to
bf990ca
Compare
|
@iameli shall we merge this? |
|
@thomshutt Let me rebase, but I seem to recall this not solving the problem it was supposed to |
So... this shouldn't be necessary. `protoc` is needed to build the files in `net` like `net/lp_rpc.pb.go`. Those files are committed to the repo; `make` shouldn't be rebuilding them. And yet, every so often, we get an error on build that [looks like this](https://github.com/livepeer/go-livepeer/actions/runs/6630250258/job/18011282601?pr=2886): ``` protoc -I=. --go_out=plugins=grpc:. net/lp_rpc.proto /bin/bash: line 1: protoc: command not found make: *** [Makefile:7: net/lp_rpc.pb.go] Error 127 Error: Process completed with exit code 2. ``` I don't know why that happens. It doesn't happen once you rebuild. But... regenerating those files is harmless, I guess, so this will stop that for everybody forever. IDK.
iameli
force-pushed
the
eli/protoc-on-build
branch
from
6e35ba5 to
a327af4
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... this shouldn't be necessary.
protocis needed to build the files innetlikenet/lp_rpc.pb.go. Those files are committed to the repo;makeshouldn't be rebuilding them. And yet, every so often, we get an error on build that looks like this:I don't know why that happens. It doesn't happen once you rebuild. But... regenerating those files is harmless, I guess, so this will stop that for everybody forever. IDK.