Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update OS storage to be same on all pipelines #3092

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore: update OS storage to be same on all pipelines #3092

merged 1 commit into from
Jul 4, 2024

Conversation

ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)
Updates the OS storage used by aiRequestParams on ImageToImage and Upscale pipelines to use requestID similar to TextToImage and ImageToVideo.

Specific updates (required)

  • Updated drivers.NodeStorage.NewSession to use requestID created in handler to use as path for URL to download results.

How did you test each of these updates (required)

  • not needed, replacing random manifest ID with random manifest ID created a few lines up in handler.

Does this pull request close any open issues?

Checklist:

@ad-astra-video ad-astra-video requested a review from rickstaa as a code owner July 2, 2024 15:43
@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Jul 2, 2024
rickstaa
rickstaa reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@rickstaa rickstaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice catch thanks!

@rickstaa rickstaa merged commit f2c9bb6 into livepeer:ai-video Jul 4, 2024
8 of 10 checks passed
This was referenced Jul 14, 2024
Merged
Closed
Merged
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Jul 26, 2024
@ad-astra-video @eliteprox
chore: update Image2Image and Upscale OS storage to use requestID sim…
82ee7c6 
…ilar to Text2Image and Image2Video (livepeer#3092)
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Jul 26, 2024
@ad-astra-video @eliteprox
chore: update Image2Image and Upscale OS storage to use requestID sim…
0fb62b7 
…ilar to Text2Image and Image2Video (livepeer#3092)
@rickstaa rickstaa mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickstaa rickstaa rickstaa left review comments

Assignees
No one assigned
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ad-astra-video @rickstaa