Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add AI service registry info log line #3362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Jan 21, 2025

What does this pull request do? Explain your changes. (required)

This pull request logs when the AI ServiceRegistry is used instead of the regular registry.

Specific updates (required)

  • Added one log line in starter.go.

How did you test each of these updates (required)

Run the binary.

Does this pull request close any open issues?

No.

Checklist:

@rickstaa rickstaa requested a review from victorges January 21, 2025 10:04
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 21, 2025
@rickstaa rickstaa force-pushed the add_ai_service_registry_info_log branch from b253fda to f858b28 Compare January 21, 2025 10:06
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.69559%. Comparing base (56ab75e) to head (57250f1).

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3362         +/-   ##
===================================================
- Coverage   33.70183%   33.69559%   -0.00624%     
===================================================
  Files            141         141                 
  Lines          37449       37450          +1     
===================================================
- Hits           12621       12619          -2     
- Misses         24107       24110          +3     
  Partials         721         721                 
Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.50939% <0.00000%> (-0.00470%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ab75e...57250f1. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.50939% <0.00000%> (-0.00470%) ⬇️

... and 2 files with indirect coverage changes

@rickstaa rickstaa force-pushed the add_ai_service_registry_info_log branch from e9e0922 to 6b942c0 Compare January 23, 2025 11:01
This commit logs when the AI ServiceRegistry is used instead of the
regular registry.
@rickstaa rickstaa force-pushed the add_ai_service_registry_info_log branch from 6b942c0 to 57250f1 Compare January 23, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants