Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct URL unmarshal error #3364

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Jan 21, 2025

What does this pull request do? Explain your changes. (required)

This pull request addresses an issue where the URL field in the /status response was not properly unmarshalled as a URL, resulting in a cannot unmarshal string into Go struct field error. The fix ensures correct unmarshalling for seamless handling of the response.

Specific updates (required)

  • Added custom unmarshall logic to the OrchestratorLocalInfo type.

How did you test each of these updates (required)

Test it on-chain.

Does this pull request close any open issues?

None.

Checklist:

@github-actions github-actions bot added the go Pull requests that update Go code label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 33.69916%. Comparing base (a1800dc) to head (97a0059).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
common/types.go 0.00000% 17 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3364         +/-   ##
===================================================
- Coverage   33.71447%   33.69916%   -0.01531%     
===================================================
  Files            141         141                 
  Lines          37432       37449         +17     
===================================================
  Hits           12620       12620                 
- Misses         24091       24108         +17     
  Partials         721         721                 
Files with missing lines Coverage Δ
common/types.go 0.00000% <0.00000%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1800dc...97a0059. Read the comment docs.

Files with missing lines Coverage Δ
common/types.go 0.00000% <0.00000%> (ø)

... and 2 files with indirect coverage changes

This commit addresses an issue where the `URL` field in the `/status` response
was not properly unmarshalled as a URL, resulting in a
`cannot unmarshal string into Go struct field` error. The fix ensures correct
unmarshalling for seamless handling of the response.
@rickstaa rickstaa force-pushed the fix_cli_url_unmarshalling_issue branch from 25eb441 to 516c1fd Compare January 23, 2025 11:01
@rickstaa rickstaa merged commit 56ab75e into master Jan 23, 2025
17 of 18 checks passed
@rickstaa rickstaa deleted the fix_cli_url_unmarshalling_issue branch January 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants