ai/live: Cancel ffmpeg exec when segmenter exits. #3367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents ffmpeg from reading indefinitely when there is no segment handling attached. That in turn can lead to disk filling up since ffmpeg writes segments to disk without removing them.
Also use context logging for some segmenter error messages.
Couldn't quite reproduce the buggy behavior we see in prod in order to completely verify this fix locally but I think this should be close enough for some cases.