move saved query UI components ⇒ NP (elastic#51870) (elastic#51980)

* move saved query UI components to NP

* Fixed search bar test

* Added service to siem mock

* change import css

src/legacy/core_plugins/data/public/index.scss

@@ -2,8 +2,4 @@
 
 @import './query/query_bar/index';
 
-@import 'src/plugins/data/public/ui/filter_bar/index';
-
-@import 'src/plugins/data/public/ui/typeahead/index';
-
-@import './search/search_bar/index';
+@import '../../../../plugins/data/public/ui/index'

src/legacy/core_plugins/data/public/search/search_bar/components/search_bar.test.tsx

@@ -38,7 +38,6 @@ const mockTimeHistory = {
 jest.mock('../../../../../../../plugins/data/public', () => {
   return {
     FilterBar: () => <div className="filterBar" />,
-    createSavedQueryService: () => {},
   };
 });
 
@@ -106,6 +105,11 @@ function wrapSearchBarInContext(testProps: any) {
     notifications: startMock.notifications,
     http: startMock.http,
     storage: createMockStorage(),
+    data: {
+      query: {
+        savedQueries: {},
+      },
+    },
   };
 
   return (

src/legacy/core_plugins/data/public/search/search_bar/components/search_bar.tsx

@@ -26,8 +26,6 @@ import { get, isEqual } from 'lodash';
 
 import { IndexPattern } from '../../../../../data/public';
 import { QueryBarTopRow } from '../../../query';
-import { SavedQueryMeta, SaveQueryForm } from './saved_query_management/save_query_form';
-import { SavedQueryManagementComponent } from './saved_query_management/saved_query_management_component';
 
 import {
   withKibana,
@@ -40,10 +38,11 @@ import {
   esFilters,
   TimeHistoryContract,
   FilterBar,
-  SavedQueryService,
-  createSavedQueryService,
   SavedQuery,
   SavedQueryAttributes,
+  SavedQueryMeta,
+  SaveQueryForm,
+  SavedQueryManagementComponent,
 } from '../../../../../../../plugins/data/public';
 
 interface SearchBarInjectedDeps {
@@ -112,8 +111,8 @@ class SearchBarUI extends Component<SearchBarProps, State> {
     showAutoRefreshOnly: false,
   };
 
-  private savedQueryService!: SavedQueryService;
   private services = this.props.kibana.services;
+  private savedQueryService = this.services.data.query.savedQueries;
   public filterBarRef: Element | null = null;
   public filterBarWrapperRef: Element | null = null;
 
@@ -368,9 +367,6 @@ class SearchBarUI extends Component<SearchBarProps, State> {
       this.setFilterBarHeight();
       this.ro.observe(this.filterBarRef);
     }
-    if (this.services.savedObjects) {
-      this.savedQueryService = createSavedQueryService(this.services.savedObjects.client);
-    }
   }
 
   public componentDidUpdate() {

src/plugins/data/public/index_patterns/index.ts

@@ -17,12 +17,12 @@
  * under the License.
  */
 
-import { IndexPatternMissingIndices } from './errors';
 import {
   ILLEGAL_CHARACTERS_KEY,
   CONTAINS_SPACES_KEY,
   ILLEGAL_CHARACTERS_VISIBLE,
   ILLEGAL_CHARACTERS,
+  IndexPatternMissingIndices,
   validateIndexPattern,
 } from './lib';
 import { getRoutes, getFromSavedObject } from './utils';

src/plugins/data/public/index_patterns/errors.ts → src/plugins/data/public/index_patterns/lib/errors.ts

@@ -19,7 +19,7 @@
 
 /* eslint-disable */
 
-import { KbnError } from '../../../kibana_utils/public';
+import { KbnError } from '../../../../kibana_utils/public';
 
 /**
  * Tried to call a method that relies on SearchSource having an indexPattern assigned

src/plugins/data/public/index_patterns/lib/index.ts

@@ -20,3 +20,4 @@
 export { getTitle } from './get_title';
 export * from './types';
 export { validateIndexPattern } from './validate_index_pattern';
+export { IndexPatternMissingIndices } from './errors';

src/plugins/data/public/suggestions_provider/value_suggestions.test.ts

@@ -17,9 +17,6 @@
  * under the License.
  */
 
-// TODO: remove when index patterns are moved here.
-jest.mock('ui/new_platform');
-
 import { stubIndexPattern, stubFields } from '../stubs';
 import { getSuggestionsProvider } from './value_suggestions';
 import { IUiSettingsClient } from 'kibana/public';

src/plugins/data/public/ui/_index.scss

@@ -0,0 +1,6 @@
+
+@import './filter_bar/index';
+
+@import './typeahead/index';
+
+@import './saved_query_management/index';

src/plugins/data/public/ui/filter_bar/filter_editor/lib/filter_editor_utils.test.ts

@@ -36,8 +36,6 @@ import {
 
 import { existsOperator, isBetweenOperator, isOneOfOperator, isOperator } from './filter_operators';
 
-jest.mock('ui/new_platform');
-
 describe('Filter editor utils', () => {
   describe('getFieldFromFilter', () => {
     it('should return the field from the filter', () => {

src/plugins/data/public/ui/index.ts

@@ -21,5 +21,7 @@ export { SuggestionsComponent } from './typeahead/suggestions_component';
 export { IndexPatternSelect } from './index_pattern_select';
 export { FilterBar } from './filter_bar';
 export { applyFiltersPopover } from './apply_filters';
-// temp export
+// temp export - will be removed as final components are migrated to NP
 export { QueryLanguageSwitcher } from './query_string_input/language_switcher';
+export { SavedQueryManagementComponent } from './saved_query_management';
+export { SaveQueryForm, SavedQueryMeta } from './saved_query_form';

src/plugins/data/public/ui/saved_query_form/index.ts

@@ -0,0 +1,20 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export { SavedQueryMeta, SaveQueryForm } from '../saved_query_form/save_query_form';

src/legacy/core_plugins/data/public/search/search_bar/components/saved_query_management/save_query_form.tsx → src/plugins/data/public/ui/saved_query_form/save_query_form.tsx

@@ -35,11 +35,7 @@ import {
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { sortBy, isEqual } from 'lodash';
-import {
-  SavedQuery,
-  SavedQueryAttributes,
-  SavedQueryService,
-} from '../../../../../../../../plugins/data/public';
+import { SavedQuery, SavedQueryAttributes, SavedQueryService } from '../..';
 
 interface Props {
   savedQuery?: SavedQueryAttributes;

src/plugins/data/public/ui/saved_query_management/index.ts

@@ -0,0 +1,20 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export { SavedQueryManagementComponent } from './saved_query_management_component';

src/legacy/core_plugins/data/public/search/search_bar/components/saved_query_management/saved_query_list_item.tsx → src/plugins/data/public/ui/saved_query_management/saved_query_list_item.tsx

@@ -22,7 +22,7 @@ import { EuiListGroupItem, EuiConfirmModal, EuiOverlayMask, EuiIconTip } from '@
 import React, { Fragment, useState } from 'react';
 import classNames from 'classnames';
 import { i18n } from '@kbn/i18n';
-import { SavedQuery } from '../../../../../../../../plugins/data/public';
+import { SavedQuery } from '../..';
 
 interface Props {
   savedQuery: SavedQuery;

src/legacy/core_plugins/data/public/search/search_bar/components/saved_query_management/saved_query_management_component.tsx → src/plugins/data/public/ui/saved_query_management/saved_query_management_component.tsx

@@ -35,7 +35,7 @@ import {
 import { i18n } from '@kbn/i18n';
 import React, { FunctionComponent, useEffect, useState, Fragment } from 'react';
 import { sortBy } from 'lodash';
-import { SavedQuery, SavedQueryService } from '../../../../../../../../plugins/data/public';
+import { SavedQuery, SavedQueryService } from '../..';
 import { SavedQueryListItem } from './saved_query_list_item';
 
 const perPage = 50;

x-pack/legacy/plugins/siem/public/mock/test_providers.tsx

@@ -58,6 +58,11 @@ const services = {
   storage: {
     get: () => {},
   },
+  data: {
+    query: {
+      savedQueries: {},
+    },
+  },
 };
 
 const localStorageMock = () => {