feat(server): implement syncer service APIs #336
Conversation
|
|
||
| // DeleteKubernetesObject deletes a kubernetes object. | ||
| func (ss *SS) DeleteKubernetesObject(ctx context.Context, req *v1.DeleteKubernetesObjectRequest) (*v1.DeleteKubernetesObjectResponse, error) { | ||
| apikey, err := auth.ExtractTokenFromContext(ctx) |
There was a problem hiding this comment.
how about adding the request validation (e.g., return an error if req.ClusterId is empty)?
|
|
||
| // PatchKubernetesObject applies a kubernetes object. | ||
| func (ss *SS) PatchKubernetesObject(ctx context.Context, req *v1.PatchKubernetesObjectRequest) (*v1.PatchKubernetesObjectResponse, error) { | ||
| userInfo, ok := auth.ExtractUserInfoFromContext(ctx) |
There was a problem hiding this comment.
how about adding the request validation?
| return nil, err | ||
| } | ||
|
|
||
| sresult, err := ss.scheduler.Schedule(userInfo) |
There was a problem hiding this comment.
Question: Is this correct that PatchKubernetesObject is currently called when a new resource is created? My understanding is that we need to find out which cluster a resource is located when the resource is being updated.
There was a problem hiding this comment.
Yes, I have only tested the creation path currently. Eventually, to support creation and updating in this same function, I plan to store cluster info as a resource annotation in the tenant cluster and use it for updating. I'll leave a TODO comment here.
No description provided.