Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs tests] Support vim-mode-plus substitute command #178

Merged
merged 4 commits into from
May 24, 2017

Conversation

mkiken
Copy link
Contributor

@mkiken mkiken commented Mar 20, 2017

Fixes # 128.

Changes Proposed in this Pull Request:

  • Fix substitute command error in vim-mode-plus
    Error caused by searchHistory functions not existing, so I add if statements.

I have written tests for: Nothing
Sorry, I'm not sure how to test and how to write this test case...

@mkiken
Copy link
Contributor Author

mkiken commented Mar 20, 2017

test failed :(
But in my environment(vim-mode 0.66.0, ex-mode 0.14.0), substitute/,/\n/g command to abc,def,ghi, result is

abc

def,ghi

Why?
Is my environment broken?

@jazzpi
Copy link
Collaborator

jazzpi commented Mar 20, 2017

The tests are failing due to atom/text-buffer#224. If you are using an official version of Atom (i.e. downloaded from https://atom.io) and can confirm that bug, it might help speed up work on that.

However, the tests are currently not running on vim-mode-plus anyways, but one vim-mode. I'll hopefully get around to testing this soon™ though.

@mkiken
Copy link
Contributor Author

mkiken commented Mar 20, 2017

@jazzpi
I usually use Atom installed by HomeBrew.Version is 1.15.0.
I try to command above using official version Atom(version 1.15.0), and confirm above bug.

I hope this helps.

@jazzpi
Copy link
Collaborator

jazzpi commented May 24, 2017

I'll rewrite the specs myself, it's not actually too much effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants