Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports Vim's gdefault option. #191

Merged
merged 5 commits into from
Aug 15, 2017
Merged

Supports Vim's gdefault option. #191

merged 5 commits into from
Aug 15, 2017

Conversation

mkiken
Copy link
Contributor

@mkiken mkiken commented Aug 13, 2017 •
edited
Loading

Changes Proposed in this Pull Request:

  • Add gdefault, nogdefault command
  • Add Gdefault GUI setting

I have written tests for:

  • New features introduced

@mkiken mkiken changed the title Supports Vim's default option. Supports Vim's gdefault option. Aug 13, 2017
@mkiken
Copy link
Contributor Author

mkiken commented Aug 13, 2017

Why test fail...?

@hultberg
Copy link
Collaborator

@mkiken See #188, they fail because of an bug in atom.

@hultberg hultberg self-requested a review August 14, 2017 07:58
@mkiken
Copy link
Contributor Author

mkiken commented Aug 14, 2017

@hultberg The test result on my branch seems different from result on #188.
What's wrong...?

@hultberg
Copy link
Collaborator

@mkiken Indeed, looks like something new in atom as a new stable and beta has been released, just take a look at the current stable tests.

@hultberg hultberg merged commit 14f0c83 into lloeki:master Aug 15, 2017
@hultberg
Copy link
Collaborator

Thanks for this @mkiken 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hultberg hultberg hultberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkiken @hultberg