Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1 Coverage is too low #15

Merged
merged 2 commits into from
May 28, 2018
Merged

#1 Coverage is too low #15

merged 2 commits into from
May 28, 2018

Conversation

SharplEr
Copy link
Contributor

For #1
Problem
Codecov was too low and jococo checks failed.

Solution
Add some base tests.
Also, fix a problem with wrong package names in tests (which effect codecov).

@0crat
Copy link
Collaborator

0crat commented May 23, 2018

Job #15 is now in scope, role is REV

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1f0f4a0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage          ?   77.55%           
  Complexity        ?       27           
=========================================
  Files             ?        7           
  Lines             ?       98           
  Branches          ?        1           
=========================================
  Hits              ?       76           
  Misses            ?       22           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
...java/org/llorllale/cactoos/matchers/MatcherOf.java 50% <0%> (ø) 2 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0f4a0...a620407. Read the comment docs.

@SharplEr SharplEr mentioned this pull request May 26, 2018
@llorllale
Copy link
Owner

@SharplEr thanks - my bad for not realizing the wrong packages were being referenced.

Please fix all new @since tags - they should be set to 1.0

@llorllale
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 28, 2018

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a620407 into llorllale:master May 28, 2018
@rultor
Copy link
Collaborator

rultor commented May 28, 2018

@rultor merge

@llorllale Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented May 28, 2018

The job #15 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants