Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#135) TextMatcherEnvelope is now TextMatcher #195

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

victornoel
Copy link
Collaborator

Last pieces of #135.

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #195   +/-   ##
=========================================
  Coverage     98.71%   98.71%           
  Complexity      133      133           
=========================================
  Files            26       26           
  Lines           311      311           
  Branches          3        3           
=========================================
  Hits            307      307           
  Misses            4        4           
Impacted Files Coverage Δ Complexity Δ
...va/org/llorllale/cactoos/matchers/TextMatcher.java 100.00% <ø> (ø) 4.00 <0.00> (?)
.../java/org/llorllale/cactoos/matchers/EndsWith.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...a/org/llorllale/cactoos/matchers/MatchesRegex.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...ava/org/llorllale/cactoos/matchers/StartsWith.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
.../org/llorllale/cactoos/matchers/TextHasString.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...in/java/org/llorllale/cactoos/matchers/TextIs.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961d37f...88eb534. Read the comment docs.

Copy link
Contributor

@andreoss andreoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel Looks okay

@victornoel
Copy link
Collaborator Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 15, 2020

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d632abd into llorllale:master Sep 15, 2020
@rultor
Copy link
Collaborator

rultor commented Sep 15, 2020

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

@victornoel victornoel deleted the 135 branch September 15, 2020 17:33
@0crat 0crat removed the 0crat/scope label Sep 15, 2020
@0crat
Copy link
Collaborator

0crat commented Sep 15, 2020

Job audit: performer @andreoss/z/z didn't make CR comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants