[FIRRTL] Disambiguate paths when possible in ResolvePaths. #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would previously error if paths are contained in multiply instantiated modules, because there is no unique path in this case. However, we could expand out the path into multiple unique paths in this case, but this is only safe to do if the path is already used in a list where multiple paths are acceptable. This relaxes the requirement and implements the path expansion in this scenario. When we hit a multiply instantiated module, we expand out all the instance paths to that module from the owning module, and create multiple annotations and resolved paths.
mikeurbach
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
|
It helps slightly to review this with whitespace-only diffs removed. |
|
Thanks @prithayan! |
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
We would previously error if paths are contained in multiply instantiated modules, because there is no unique path in this case. However, we could expand out the path into multiple unique paths in this case, but this is only safe to do if the path is already used in a list where multiple paths are acceptable. This relaxes the requirement and implements the path expansion in this scenario. When we hit a multiply instantiated module, we expand out all the instance paths to that module from the owning module, and create multiple annotations and resolved paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would previously error if paths are contained in multiply instantiated modules, because there is no unique path in this case. However, we could expand out the path into multiple unique paths in this case, but this is only safe to do if the path is already used in a list where multiple paths are acceptable.
This relaxes the requirement and implements the path expansion in this scenario. When we hit a multiply instantiated module, we expand out all the instance paths to that module from the owning module, and create multiple annotations and resolved paths.