Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][CAPI] Add function for getting mask type #6944

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[FIRRTL][CAPI] Add function for getting mask type #6944

merged 1 commit into from
Apr 22, 2024

Conversation

SpriteOvO
Copy link
Member

Used for building firrtl.mem from external programs.

circt/lib/Dialect/FIRRTL/FIRRTLOps.cpp

Line 2982 in db973f1

maskType = dataType.getMaskType();

@SpriteOvO SpriteOvO force-pushed the firrtl-capi-mask-type branch from 041416d to 24d9c10 Compare April 22, 2024 22:01
mikeurbach
mikeurbach approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for adding nice unit tests.

@SpriteOvO SpriteOvO merged commit 172b5ea into llvm:main Apr 22, 2024
4 checks passed
@SpriteOvO SpriteOvO deleted the firrtl-capi-mask-type branch April 22, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpriteOvO @mikeurbach