[FIRRTL] Cache symbol table in LowerLayers #7436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
reviewed
Aug 5, 2024
youngar
reviewed
Aug 5, 2024
Precompute a symbol to layer mapping inside LowerLayers and uses this instead of a symbol table. This is both faster and avoids problems of trying to compute a symbol table while modules may be created. Repurpose the functions that were being used to create macro declarations to also compute this symbol to layer mapping. Rename these to indicate that they are now doing generic layer preprocessing. Fixes #7434. h/t @youngar for the fix suggestion. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/issue-7434
branch
from
e3cc671 to
46326f7
Compare
seldridge
commented
Aug 6, 2024
Comment on lines
-126
to
+127
| static SmallString<32> macroNameForLayer(ArrayRef<StringAttr> layerName) { | ||
| static SmallString<32> | ||
| macroNameForLayer(ArrayRef<FlatSymbolRefAttr> layerName) { |
There was a problem hiding this comment.
This change, and others that are s/StringAttr/FlatSymbolRefAttr/ exist because the former is always trivially accessible from the latter while the latter is necessary for constructing SymbolRefAttrs. This became necessary due to wanting to compute macros and the SymbolRefAttr -> LayerOp mapping at the same time.
rwy7
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompute a symbol table inside LowerLayers in order to do SymbolRefAttr -> LayerOp lookups. This is expected to fix an intermittent crash as well as improve performance.
Fixes #7434.
h/t @youngar for the fix suggestion.