[FIRRTL][InferResets] Generalize FART to support sync reset #7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
force-pushed
the
dev/jackkoenig/fart-to-frt
branch
from
6ec0d21 to
75619d0
Compare
jackkoenig
commented
Aug 8, 2024
fabianschuiki
approved these changes
Aug 9, 2024
dobios
reviewed
Aug 9, 2024
dobios
reviewed
Aug 9, 2024
The FullAsyncResetAnnotation is deprecated and replaced by FullResetAnnotation which includes a resetType argument that must be 'sync' or 'async'. IgnoreFullAsyncResetAnnotation is deprecated and replaced by ExcludeFromFullResetAnnotation. The new annotations are in package circt. The behavior of FullResetAnnotation with resetType = 'async' is identical to that of the old FullAsyncResetAnnotation. The behavior of FullResetAnnotation with resetType = 'sync' is very similar, except the type of the reset wired through will be UInt<1>, and any registers with an existing reset at all (both sync or async) will be left unchanged (resetType = 'async' will add async resets to registers with existing sync resets).
jackkoenig
force-pushed
the
dev/jackkoenig/fart-to-frt
branch
from
75619d0 to
bc805bb
Compare
dobios
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FullAsyncResetAnnotation is deprecated and replaced by FullResetAnnotation which includes a resetType argument that must be 'sync' or 'async'. IgnoreFullAsyncResetAnnotation is deprecated and replaced by ExcludeFromFullResetAnnotation. The new annotations are in package circt.
The behavior of FullResetAnnotation with resetType = 'async' is identical to that of the old FullAsyncResetAnnotation. The behavior of FullResetAnnotation with resetType = 'sync' is very similar, except the type of the reset wired through will be UInt<1>, and any registers with an existing reset at all (both sync or async) will be left unchanged (resetType = 'async' will add async resets to registers with existing sync resets).