Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending LLDB to work on AIX #101657

Closed
DhruvSrivastavaX opened this issue Aug 2, 2024 · 4 comments
Closed

Extending LLDB to work on AIX #101657

DhruvSrivastavaX opened this issue Aug 2, 2024 · 4 comments
Labels
lldb platform:aix question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!

Comments

@DhruvSrivastavaX
Copy link
Contributor

DhruvSrivastavaX commented Aug 2, 2024 •
edited
Loading

Hi Community Members,

We have Implemented the necessary code changes required to run LLDB on AIX.

Since AIX wants to be the part of LLDB community, and want their feature enhancements to work with the Community
to extend support of LLDB to AIX as well, we would like to contribute changes required to run LLDB on AIX via a Pull Request.

Kindly let us know if we can. Once we raise the PR, also let us know if we can have a better design to the code changes from your experience, so that we can make it easy to maintain for you and AIX. We would like our code to be a part of the next release of the LLDB Project and actively involve in maintaining LLDB on AIX and the Community.

Thanks & Regards,
Dhruv Srivastava
IBM
@asl
Copy link
Collaborator

asl commented Aug 2, 2024 •
edited
Loading

You do not need a permission to open a PR provided that is follows LLVM's Contribution Guidelines: https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

If you'd need to discuss something, you can always submit and RFC to LLVM Discourse

@asl asl closed this as completed Aug 2, 2024
@asl asl added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Aug 2, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2024

@llvm/issue-subscribers-lldb

Author: None (Dhruv-Srivastava-IBM)

Hi Community Members,

We have Implemented the necessary code changes required to run LLDB on AIX.

Since AIX wants to be the part of LLDB community, and want their feature enhancements to work with the Community
to extend support of LLDB to AIX as well, we would like to contribute changes required to run LLDB on AIX via a Pull Request.

Kindly let us know if we can. Once we raise the PR, also let us know if we can have a better design to the code changes from your experience, so that we can make it easy to maintain for you and AIX. We would like our code to be a part of the next release of the LLDB Project and actively involve in maintaining LLDB on AIX and the Community.

Thanks & Regards,
Dhruv Srivastava
IBM

@DavidSpickett
Copy link
Collaborator

If you'd need to discuss something, you can always submit and RFC to LLVM Discourse

Yes, please start a thread in https://discourse.llvm.org/c/subprojects/lldb/8 going over what AIX is, your goals in doing this support, how it will be tested, who the code owners will be, link to some WIP changes and any other information you think will be helpful for us to understand the platform.

@DhruvSrivastavaX
Copy link
Contributor Author

Okay Thanks for the inputs.
I will start a conversation regarding the same on discourse and mention the details over there.

DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 5, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
a93b5a7
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 9, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
a2f162d
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Aug 9, 2024
Draft
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 12, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
d1e3ac5
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 16, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
061180f
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Aug 17, 2024
Merged
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 20, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
b3b75da
DavidSpickett pushed a commit that referenced this issue Aug 20, 2024
@DhruvSrivastavaX
[lldb][AIX] 1. Avoid namespace collision on other platforms (#104679)
b804516 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:
1.  https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2.  #101657 

The complete changes for porting are present in this draft PR:
#102601

The changes on this PR are intended to avoid namespace collision for
certain typedefs between lldb and other platforms:
1. tid_t --> lldb::tid_t
2. offset_t --> lldb::offset_t
This was referenced Aug 21, 2024
Closed
Merged
DavidSpickett pushed a commit that referenced this issue Aug 22, 2024
@DhruvSrivastavaX
[lldb][AIX] Updating XCOFF,PPC entry in LLDB ArchSpec (#105523)
1b664fe 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657 

The complete changes for porting are present in this draft PR:
#102601 

The changes in this PR are intended to update the Architecture entry for
LLDB with XCOFF,PPC.

1. Added new ArchitectureType `eArchTypeXCOFF`
2. Added a new `ArchDefinitionEntry g_xcoff_arch_entries[]`
3. Added a new case for `XCOFF in ArchSpec::SetArchitecture(..)`
4. Updated `ArchDefinition *g_arch_definitions[]`
Lakshmi-Surekha pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 23, 2024
Changes made after getting merge conflict while porting AIX code into…
ae7a76e 
… LLDB

Merge remote-tracking branch 'upstream/main' into llvmgh-101657
cjdb pushed a commit to cjdb/llvm-project that referenced this issue Aug 23, 2024
@DhruvSrivastavaX @cjdb
[lldb][AIX] Updating XCOFF,PPC entry in LLDB ArchSpec (llvm#105523)
f873b5f 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm#101657 

The complete changes for porting are present in this draft PR:
llvm#102601 

The changes in this PR are intended to update the Architecture entry for
LLDB with XCOFF,PPC.

1. Added new ArchitectureType `eArchTypeXCOFF`
2. Added a new `ArchDefinitionEntry g_xcoff_arch_entries[]`
3. Added a new case for `XCOFF in ArchSpec::SetArchitecture(..)`
4. Updated `ArchDefinition *g_arch_definitions[]`
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 30, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
094e590
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Sep 1, 2024
Open
dmpolukhin pushed a commit to dmpolukhin/llvm-project that referenced this issue Sep 2, 2024
@DhruvSrivastavaX @dmpolukhin
[lldb][AIX] Updating XCOFF,PPC entry in LLDB ArchSpec (llvm#105523)
059a659 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm#101657 

The complete changes for porting are present in this draft PR:
llvm#102601 

The changes in this PR are intended to update the Architecture entry for
LLDB with XCOFF,PPC.

1. Added new ArchitectureType `eArchTypeXCOFF`
2. Added a new `ArchDefinitionEntry g_xcoff_arch_entries[]`
3. Added a new case for `XCOFF in ArchSpec::SetArchitecture(..)`
4. Updated `ArchDefinition *g_arch_definitions[]`
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Sep 4, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
f7fb892
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Sep 10, 2024
Closed
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Sep 12, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
9c95e79
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Sep 17, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
163e510
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Jan 10, 2025
@DhruvSrivastavaX @github-actions
Automerge: [lldb] AIX Changes for MainLoop polling (#120378)
95a4b74 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

Dropping changes for MainLoop polling in AIX, as `ppoll` is not
supported in AIX currently.
This change is part of the couple of minimal changes required to build a
minimal `lldb` binary on AIX
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Jan 10, 2025
@DhruvSrivastavaX @github-actions
Automerge: [lldb] clang-format changes for some basic #if _AIX change…
6441b95 
…s (#120978)

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

Added clang-format changes for changes related to some base #if _AIX
changes:

- llvm/llvm-project#120979
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Jan 10, 2025
@DhruvSrivastavaX @github-actions
Automerge: [lldb][AIX] HostInfoAIX Support (#117906)
09ce8c4 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

Added a HostInfoAIX file for the AIX platform.
Most of the common functionalities are handled by the parent
HostInfoPosix now,
So we just have some basic functions implemented here.
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Jan 10, 2025
@DhruvSrivastavaX @github-actions
Automerge: [lldb][AIX] Some base #if _AIX changes of a minimal lldb b…
579cfb0 
…uild (#120979)

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

Added some base #if _AIX changes for minimal lldb build.
Added a PR for clang-format changes separately, to rebase this on later:

- llvm/llvm-project#120978

Review Request: @labath @DavidSpickett
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Jan 10, 2025
@Lakshmi-Surekha @github-actions
Automerge: [lldb][AIX] Added support for AIX in HostInfo section (#12…
9ecaa5c 
…2301)

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
llvm/llvm-project#101657
2. The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601
Added support for AIX in HostInfo section

Review Request : @DavidSpickett @labath @DhruvSrivastavaX
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 10, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
ad2c204
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 10, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
72de919
Lakshmi-Surekha added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 11, 2025
@Lakshmi-Surekha
Merge branch 'llvm:main' into llvmgh-101657
79e9625
BaiXilin pushed a commit to BaiXilin/llvm-fix-vnni-instr-types that referenced this issue Jan 12, 2025
@Lakshmi-Surekha @BaiXilin
[lldb][AIX] Added support for AIX in HostInfo section (llvm#122301)
2a2be73 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
llvm#101657
2. The complete changes for porting are present in this draft PR:
llvm#102601
Added support for AIX in HostInfo section

Review Request : @DavidSpickett @labath @DhruvSrivastavaX
Lakshmi-Surekha added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 13, 2025
@Lakshmi-Surekha
Merge branch 'llvm:main' into llvmgh-101657
84ab2f0
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 13, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
aefbbbf
Mel-Chen pushed a commit to Mel-Chen/llvm-project that referenced this issue Jan 13, 2025
@Lakshmi-Surekha @Mel-Chen
[lldb][AIX] Added support for AIX in HostInfo section (llvm#122301)
19e6f1e 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
llvm#101657
2. The complete changes for porting are present in this draft PR:
llvm#102601
Added support for AIX in HostInfo section

Review Request : @DavidSpickett @labath @DhruvSrivastavaX
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 13, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
847230b
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 13, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
cab9674
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 14, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
054733b
Lakshmi-Surekha added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 15, 2025
@Lakshmi-Surekha
Merge branch 'llvm:main' into llvmgh-101657
b01e24c
Lakshmi-Surekha added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 16, 2025
@Lakshmi-Surekha
Merge branch 'llvm:main' into llvmgh-101657
26a3c23
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 17, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
befb24c
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 17, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
68e0c4c
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 17, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
b4d4329
DKLoehr pushed a commit to DKLoehr/llvm-project that referenced this issue Jan 17, 2025
@Lakshmi-Surekha @DKLoehr
[lldb][AIX] Added support for AIX in HostInfo section (llvm#122301)
ad233e0 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
llvm#101657
2. The complete changes for porting are present in this draft PR:
llvm#102601
Added support for AIX in HostInfo section

Review Request : @DavidSpickett @labath @DhruvSrivastavaX
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 17, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
49cc9bb
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 18, 2025
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
f428ca6
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 19, 2025
@DhruvSrivastavaX
Merge branch 'llvmgh-101657' into core-support-aix
85d69a9
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 20, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
cd39f0a
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 20, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
ddcf64f
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 21, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
626c018
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 22, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
3903792
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 23, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
8a464f3
ravi-sh added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Jan 24, 2025
@ravi-sh
Merge branch 'llvm:main' into llvmgh-101657
98de95c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lldb platform:aix question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asl @DavidSpickett @EugeneZelenko @llvmbot @DhruvSrivastavaX