[clang-format] AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

[mydeveloperday]

Bugzilla Link	50326
Resolution	FIXED
Resolved on	Jun 03, 2021 23:25
Version	12.0
OS	Windows NT
Blocks	#48661
CC	@tstellar
Fixed by commit(s)	eae445f e673593

Extended Description

With a .clang-format of

Language: Cpp
BasedOnStyle: LLVM
AlignAfterOpenBracket: AlwaysBreak
...

The follow file does not break the last line (foo4) at the ColumnLimit

---

void bar()
{
size_t foo1 = function(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong);

size_t foo2 = function(
    Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
    FoooooooooLooooong);

size_t foo3 = (*(function))(Foooo, Barrrrr, Foooo, FoooooooooLooooong);

size_t foo4 = (*(
    function))(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong, FoooooooooLooooong);

}

It fees like the correct should be

---

void bar()
{
size_t foo = function(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong);

size_t foo = function(
    Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
    FoooooooooLooooong);

size_t foo = (*(function))(Foooo, Barrrrr, Foooo, FoooooooooLooooong);

size_t foo = (*(
    function))(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong,
    BarrrrrrrrrrrrLong, FoooooooooLooooong);

}

[mydeveloperday]

Present in clang-12 seems like a regression

v8 was

void bar() {
size_t foo = function(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong);

size_t foo = function(
Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
FoooooooooLooooong);

size_t foo = (*(function))(Foooo, Barrrrr, Foooo, FoooooooooLooooong);

size_t foo = (*(function))(
Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
FoooooooooLooooong);
}

[mydeveloperday]

Actually this is a version 11GA -> 12GA regression, as v11 is fine also

void bar() {
size_t foo = function(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong);

size_t foo = function(
Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
FoooooooooLooooong);

size_t foo = (*(function))(Foooo, Barrrrr, Foooo, FoooooooooLooooong);

size_t foo = (*(function))(
Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
FoooooooooLooooong);
}

[mydeveloperday]

This is caused by 5426b2f https://reviews.llvm.org/D93626

[mydeveloperday]

Tentative fix https://reviews.llvm.org/D102392

[mydeveloperday]

We should try and get this put into 12.0.1 as its not the first time this bug has been seen

[mydeveloperday]

Tom I've marked this as Blocks "release-12.0.1" if you want to move that to something later like 12.0.2 that is completely fine.

[tstellar]

Merged: e673593