Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir][spirv] Add missing folding for scalar/vector SPIR-V ops #70704

Closed
inbelic opened this issue Oct 30, 2023 · 3 comments
Closed

[mlir][spirv] Add missing folding for scalar/vector SPIR-V ops #70704

inbelic opened this issue Oct 30, 2023 · 3 comments
Assignees
@inbelic
Labels
mlir:spirv

Comments

@inbelic
Copy link
Contributor

inbelic commented Oct 30, 2023

It has been noted that we are missing the fold definitions for various basic scalar/vector SPIR-V ops. As a result, many of these operations are not folded away in the IR and it is required to use other tools to do so, eg: spirv-opt. We are motivated to do so as it would allow for the IR to be more readable, particularly when we have transformed/lowered from another dialect into SPIR-V and are generating new operations that have the potential to be folded away.
@inbelic
Copy link
Contributor Author

inbelic commented Oct 30, 2023

I have begun work on this and will add a draft PR in the next couple days.

@kuhar I will ping you here to follow along and to request that you assign me to the issue as well, thanks.

@kuhar kuhar changed the title [SPIRV] Add missing folding for scalar/vector SPIR-V ops [mlir][spirv] Add missing folding for scalar/vector SPIR-V ops Oct 30, 2023
@llvmbot
Copy link
Member

llvmbot commented Oct 30, 2023

@llvm/issue-subscribers-mlir-spirv

Author: Finn Plummer (inbelic)

It has been noted that we are missing the fold definitions for various basic scalar/vector SPIR-V ops. As a result, many of these operations are not folded away in the IR and it is required to use other tools to do so, eg: spirv-opt. We are motivated to do so as it would allow for the IR to be more readable, particularly when we have transformed/lowered from another dialect into SPIR-V and are generating new operations that have the potential to be folded away.

@inbelic inbelic mentioned this issue Nov 6, 2023
Closed
inbelic added a commit to inbelic/llvm-project that referenced this issue Nov 21, 2023
@inbelic
[mlir][spirv] Add missed arith op folds
5c42f59 
We have missing basic constant folds for SPIR-V arithmetic operations which
negatively impacts readability of lowered or otherwise generated code. This
commit works to implementing them to improve the mentioned hinderences.
Also corrects some folds that were found to be incorrect during testing.

Resolves llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Nov 21, 2023
@inbelic
[mlir][spirv] Add missed bit op folds
d90ff6d 
We have missing basic constant folds for SPIR-V bit operations which
negatively impacts readability of lowered or otherwise generated code. This
commit works to implementing them to improve the mentioned hinderences.

Resolves llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Nov 21, 2023
@inbelic
[mlir][spirv] Add missed logical op folds
f252ccf 
We have missing basic constant folds for SPIR-V logical operations which
negatively impacts readability of lowered or otherwise generated code. This
commit works to implementing them to improve the mentioned hinderences.
Corrects some testcases in logical-ops-to-llvm as required.

Resolves llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Nov 24, 2023
@inbelic
[mlir][spirv] Add folding for IAddCarry/[S|U]MulExtended
dcbfc96 
Add missing constant propogation folder for IAddCarry and
[S|U]MulExtended. Due to currently missing constant value for
spirv.struct the folding is done using canonicalization patterns.

Implement additional folding when rhs is 0 for all ops and when rhs
is 1 for UMulExt.

This helps for readability of lowered code into SPIRV.

Part of work for llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Nov 24, 2023
@inbelic
[mlir][spirv] Add folding for [S|U]Mod, [S|U]Div, SRem
1429c56 
Add missing constant propogation folder for [S|U]Mod, [S|U]Div, SRem

Implement additional folding when rhs is 1 for all ops.

This helps for readability of lowered code into SPIR-V.

Part of work for llvm#70704
This was referenced Nov 24, 2023
Merged
Merged
kuhar pushed a commit that referenced this issue Nov 29, 2023
@inbelic
[mlir][spirv] Add folding for [S|U]Mod, [S|U]Div, SRem (#73341)
5259e14 
Add missing constant propogation folder for [S|U]Mod, [S|U]Div, SRem

Implement additional folding when rhs is 1 for all ops.

This helps for readability of lowered code into SPIR-V.

Part of work for #70704
kuhar pushed a commit that referenced this issue Nov 29, 2023
@inbelic
[mlir][spirv] Add canon patterns for IAddCarry/[S|U]MulExtended (#73340)
14028ec 
Add missing constant propogation folder for IAddCarry and
[S|U]MulExtended. Due to currently missing constant value for
spirv.struct the folding is done using canonicalization patterns.

Implement additional folding when rhs is 0 for all ops and when rhs is 1
for UMulExt.

This helps for readability of lowered code into SPIR-V.

Part of work for #70704
@inbelic inbelic mentioned this issue Dec 2, 2023
Merged
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|LessThan[Equal]
2126757 
Add missing constant propogation folder for [S|U]LessThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Add folding for SelectOp
4998cc1 
Add missing constant propogation folder for spirv.Select

Implement additional folding when both selections are equivalent or the
condition is a constant Scalar/SplatVector.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|GreaterThan[Equal]
666823e 
Add missing constant propogation folder for [S|U]GreaterThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|GreaterThan[Equal]
f687a64 
Add missing constant propogation folder for [S|U|GreaterThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|LessThan[Equal]
83a984f 
Add missing constant propogation folder for [S|U]LessThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Add folding for SelectOp
88b1575 
Add missing constant propogation folder for spirv.Select

Implement additional folding when both selections are equivalent or the
condition is a constant Scalar/SplatVector.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Use folding in IndexToSPIRV
9271be8 
Allow for constant propogation when converting from index to SPIR-V for:
ceildiv[s|u] and floordivs.

Aims to improve readability of generated SPIR-V code.

Part of work llvm#70704
@inbelic inbelic mentioned this issue Mar 15, 2024
Merged
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 15, 2024
@inbelic
[mlir][spirv] Improve folding of MemRef to SPIRV Lowering
87c7b2e 
Investigate the lowering of MemRef Load/Store ops and implement
additional folding of created ops

Aims to improve readability of generated lowered SPIR-V code.

Part of work llvm#70704
This was referenced Mar 15, 2024
Merged
Merged
Merged
inbelic added a commit that referenced this issue Mar 19, 2024
@inbelic
[mlir][spirv] Add folding for SelectOp (#85430)
8cbb8ac 
Add missing constant propogation folder for spirv.Select

Implement additional folding when both selections are equivalent or the
condition is a constant Scalar/SplatVector.

Allows for constant folding in the IndexToSPIRV pass.

Part of work #70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 19, 2024
@inbelic
[mlir][spirv] Improve folding of MemRef to SPIRV Lowering
adc3bd2 
Investigate the lowering of MemRef Load/Store ops and implement
additional folding of created ops

Aims to improve readability of generated lowered SPIR-V code.

Part of work llvm#70704
inbelic added a commit that referenced this issue Mar 21, 2024
@inbelic
[mlir][spirv] Improve folding of MemRef to SPIRV Lowering (#85433)
38f8a3c 
Investigate the lowering of MemRef Load/Store ops and implement
additional folding of created ops

Aims to improve readability of generated lowered SPIR-V code.

Part of work #70704
chencha3 pushed a commit to chencha3/llvm-project that referenced this issue Mar 23, 2024
@inbelic @chencha3
[mlir][spirv] Add folding for SelectOp (llvm#85430)
a2f3e7a 
Add missing constant propogation folder for spirv.Select

Implement additional folding when both selections are equivalent or the
condition is a constant Scalar/SplatVector.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
chencha3 pushed a commit to chencha3/llvm-project that referenced this issue Mar 23, 2024
@inbelic @chencha3
[mlir][spirv] Improve folding of MemRef to SPIRV Lowering (llvm#85433)
e4b57ab 
Investigate the lowering of MemRef Load/Store ops and implement
additional folding of created ops

Aims to improve readability of generated lowered SPIR-V code.

Part of work llvm#70704
inbelic added a commit that referenced this issue Mar 25, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|LessThan[Equal] (#85435)
230b189 
Add missing constant propogation folder for [S|U]LessThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work #70704
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 26, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|GreaterThan[Equal]
0d744ac 
Add missing constant propogation folder for [S|U]GreaterThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work llvm#70704
inbelic added a commit that referenced this issue Mar 26, 2024
@inbelic
[mlir][spirv] Add folding for [S|U|GreaterThan[Equal] (#85434)
cc3b6f9 
Add missing constant propogation folder for [S|U]GreaterThan[Equal].

Implement additional folding when the operands are equal for all ops.

Allows for constant folding in the IndexToSPIRV pass.

Part of work #70704
@kuhar
Copy link
Member

kuhar commented Aug 6, 2024

I think this has been completed, I'm not aware of any missing folds / canon rules

@kuhar kuhar closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inbelic inbelic

Labels
mlir:spirv
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mlir][spirv] Add basic arithmetic folds inbelic/llvm-project
4 participants
@kuhar @EugeneZelenko @inbelic @llvmbot