[clang] Segfault with -module-file-info

[chestnykh]

If clang is invoked with -module-file-info and the file is of incorrect type then clang segfaults.

There is assert in the code
assert(isCurrentFileAST() && "dumping non-AST?");
Segfault occurs in release build (with disabled assertions).
Should this behavior be fixed or left unchanged?

CC: @AaronBallman @cor3ntin @Endilll

[llvmbot]

@llvm/issue-subscribers-clang-modules

Author: Dmitriy Chestnykh (chestnykh)

If clang is invoked with `-module-file-info` and the file is of incorrect type then clang segfaults.

There is assert in the code
assert(isCurrentFileAST() && "dumping non-AST?");
Segfault occurs in release build (with disabled assertions).
Should this behavior be fixed or left unchanged?

CC: @AaronBallman @cor3ntin @Endilll

[shafik]

Seems like we should provide a diagnostic instead of crashing.

CC @ChuanqiXu9

[ChuanqiXu9]

Yeah, it will be better to use a diagnostic than crashing here. The reason why it is left so long is that I thought the tool is majorly used by developers not end users. But we provide it after all. And I feel this issue is suit for beginners since beyond the background, it simply requires us to add a diagnostic for it.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Dmitriy Chestnykh (chestnykh)

If clang is invoked with `-module-file-info` and the file is of incorrect type then clang segfaults.

There is assert in the code
assert(isCurrentFileAST() && "dumping non-AST?");
Segfault occurs in release build (with disabled assertions).
Should this behavior be fixed or left unchanged?

CC: @AaronBallman @cor3ntin @Endilll

[chestnykh]

Yeah, it will be better to use a diagnostic than crashing here. The reason why it is left so long is that I thought the tool is majorly used by developers not end users. But we provide it after all. And I feel this issue is suit for beginners since beyond the background, it simply requires us to add a diagnostic for it.

Okay, I will work on this issue. Assign please it to me