Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xtensa] Implement sextload i8 #106053

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[Xtensa] Implement sextload i8 #106053

merged 2 commits into from
Aug 26, 2024

Conversation

andreisfr
Copy link
Contributor

No description provided.

@andreisfr
Copy link
Contributor Author

@arsenm , @s-barannikov , please review this PR whenever you have the time.

@s-barannikov s-barannikov changed the title [Xtensa] Implement sextload i8. [Xtensa] Implement sextload i8 Aug 26, 2024
@andreisfr andreisfr mentioned this pull request Aug 26, 2024
Open
s-barannikov
s-barannikov approved these changes Aug 26, 2024
View reviewed changes
llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
@@ -70,11 +70,12 @@ XtensaTargetLowering::XtensaTargetLowering(const TargetMachine &TM,
setOperationAction(ISD::FP_TO_UINT, MVT::i32, Expand);
setOperationAction(ISD::FP_TO_SINT, MVT::i32, Expand);

// No sign extend instructions for i1
// No sign extend instructions for i1 and sign extend load i8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments should end with a period.

llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
@@ -70,11 +70,12 @@ XtensaTargetLowering::XtensaTargetLowering(const TargetMachine &TM,
setOperationAction(ISD::FP_TO_UINT, MVT::i32, Expand);
setOperationAction(ISD::FP_TO_SINT, MVT::i32, Expand);

// No sign extend instructions for i1
// No sign extend instructions for i1 and sign extend load i8
for (MVT VT : MVT::integer_valuetypes()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW you only need to set actions for legal VTs, that is only for VT == MVT::i32.

@sstefan1 sstefan1 merged commit ea625f4 into llvm:main Aug 26, 2024
8 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 26, 2024

LLVM Buildbot has detected a new failure on builder libc-x86_64-debian running on libc-x86_64-debian while building llvm at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/43/builds/4985

Here is the relevant piece of the build log for the reference 
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[818/1003] Running unit test libc.test.src.stdlib.atol_test.__unit__
[==========] Running 3 tests from 1 test suite.
[ RUN      ] LlvmLibcAtolTest.ValidNumbers
[       OK ] LlvmLibcAtolTest.ValidNumbers (5 us)
[ RUN      ] LlvmLibcAtolTest.NonBaseTenWholeNumbers
[       OK ] LlvmLibcAtolTest.NonBaseTenWholeNumbers (1 us)
[ RUN      ] LlvmLibcAtolTest.NotNumbers
[       OK ] LlvmLibcAtolTest.NotNumbers (1 us)
Ran 3 tests.  PASS: 3  FAIL: 0
[819/1003] Running unit test libc.test.src.stdio.fscanf_test.__unit__
FAILED: projects/libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.fscanf_test.__unit__ /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.fscanf_test.__unit__ 
cd /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/test/src/stdio && /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/test/src/stdio/libc.test.src.stdio.fscanf_test.__unit__.__build__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcFScanfTest.WriteToFile
Segmentation fault
[820/1003] Running unit test libc.test.src.stdio.scanf_core.parser_test
[==========] Running 29 tests from 1 test suite.
[ RUN      ] LlvmLibcScanfParserTest.Constructor
[       OK ] LlvmLibcScanfParserTest.Constructor (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalRaw
[       OK ] LlvmLibcScanfParserTest.EvalRaw (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalSimple
[       OK ] LlvmLibcScanfParserTest.EvalSimple (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArg
[       OK ] LlvmLibcScanfParserTest.EvalOneArg (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBadArg
[       OK ] LlvmLibcScanfParserTest.EvalBadArg (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithFlag
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithFlag (3 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithWidth
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithWidth (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithShortLengthModifier
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithShortLengthModifier (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithLongLengthModifier
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithLongLengthModifier (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithAllOptions
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithAllOptions (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalSimpleBracketArg
[       OK ] LlvmLibcScanfParserTest.EvalSimpleBracketArg (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgRange
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgRange (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgTwoRanges
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgTwoRanges (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgJustHyphen
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgJustHyphen (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgLeftHyphen
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgLeftHyphen (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgRightHyphen
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgRightHyphen (2 us)
Step 7 (libc-unit-tests) failure: libc-unit-tests (failure)
...
[818/1003] Running unit test libc.test.src.stdlib.atol_test.__unit__
[==========] Running 3 tests from 1 test suite.
[ RUN      ] LlvmLibcAtolTest.ValidNumbers
[       OK ] LlvmLibcAtolTest.ValidNumbers (5 us)
[ RUN      ] LlvmLibcAtolTest.NonBaseTenWholeNumbers
[       OK ] LlvmLibcAtolTest.NonBaseTenWholeNumbers (1 us)
[ RUN      ] LlvmLibcAtolTest.NotNumbers
[       OK ] LlvmLibcAtolTest.NotNumbers (1 us)
Ran 3 tests.  PASS: 3  FAIL: 0
[819/1003] Running unit test libc.test.src.stdio.fscanf_test.__unit__
FAILED: projects/libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.fscanf_test.__unit__ /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.fscanf_test.__unit__ 
cd /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/test/src/stdio && /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian/build/projects/libc/test/src/stdio/libc.test.src.stdio.fscanf_test.__unit__.__build__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcFScanfTest.WriteToFile
Segmentation fault
[820/1003] Running unit test libc.test.src.stdio.scanf_core.parser_test
[==========] Running 29 tests from 1 test suite.
[ RUN      ] LlvmLibcScanfParserTest.Constructor
[       OK ] LlvmLibcScanfParserTest.Constructor (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalRaw
[       OK ] LlvmLibcScanfParserTest.EvalRaw (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalSimple
[       OK ] LlvmLibcScanfParserTest.EvalSimple (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArg
[       OK ] LlvmLibcScanfParserTest.EvalOneArg (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBadArg
[       OK ] LlvmLibcScanfParserTest.EvalBadArg (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithFlag
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithFlag (3 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithWidth
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithWidth (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithShortLengthModifier
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithShortLengthModifier (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithLongLengthModifier
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithLongLengthModifier (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalOneArgWithAllOptions
[       OK ] LlvmLibcScanfParserTest.EvalOneArgWithAllOptions (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalSimpleBracketArg
[       OK ] LlvmLibcScanfParserTest.EvalSimpleBracketArg (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgRange
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgRange (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgTwoRanges
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgTwoRanges (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgJustHyphen
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgJustHyphen (2 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgLeftHyphen
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgLeftHyphen (1 us)
[ RUN      ] LlvmLibcScanfParserTest.EvalBracketArgRightHyphen
[       OK ] LlvmLibcScanfParserTest.EvalBracketArgRightHyphen (2 us)

@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 26, 2024

LLVM Buildbot has detected a new failure on builder libc-x86_64-debian-dbg-runtimes-build running on libc-x86_64-debian while building llvm at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/78/builds/4662

Here is the relevant piece of the build log for the reference 
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[ RUN      ] LlvmLibcStrCSpnTest.ComplementarySpanShouldNotGoPastNullTerminator
[       OK ] LlvmLibcStrCSpnTest.ComplementarySpanShouldNotGoPastNullTerminator (4 us)
[ RUN      ] LlvmLibcStrCSpnTest.ComplementarySpanForEachIndividualCharacter
[       OK ] LlvmLibcStrCSpnTest.ComplementarySpanForEachIndividualCharacter (3 us)
[ RUN      ] LlvmLibcStrCSpnTest.ComplementarySpanIsStringLengthIfNoCharacterFound
[       OK ] LlvmLibcStrCSpnTest.ComplementarySpanIsStringLengthIfNoCharacterFound (2 us)
[ RUN      ] LlvmLibcStrCSpnTest.DuplicatedCharactersNotPartOfComplementarySpan
[       OK ] LlvmLibcStrCSpnTest.DuplicatedCharactersNotPartOfComplementarySpan (2 us)
Ran 4 tests.  PASS: 4  FAIL: 0
[1049/1202] Running unit test libc.test.src.stdio.vfscanf_test.__unit__
FAILED: libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.vfscanf_test.__unit__ /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-runtimes-build/build/runtimes/runtimes-bins/libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.vfscanf_test.__unit__ 
cd /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-runtimes-build/build/runtimes/runtimes-bins/libc/test/src/stdio && /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-runtimes-build/build/runtimes/runtimes-bins/libc/test/src/stdio/libc.test.src.stdio.vfscanf_test.__unit__.__build__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcFScanfTest.WriteToFile
Segmentation fault
[1050/1202] Running unit test libc.test.src.string.strdup_test.__unit__
[==========] Running 3 tests from 1 test suite.
[ RUN      ] LlvmLibcStrDupTest.EmptyString
[       OK ] LlvmLibcStrDupTest.EmptyString (7 us)
[ RUN      ] LlvmLibcStrDupTest.AnyString
[       OK ] LlvmLibcStrDupTest.AnyString (2 us)
[ RUN      ] LlvmLibcStrDupTest.NullPtr
[       OK ] LlvmLibcStrDupTest.NullPtr (2 us)
Ran 3 tests.  PASS: 3  FAIL: 0
[1051/1202] Running unit test libc.test.src.string.strerror_test.__unit__
[==========] Running 2 tests from 1 test suite.
[ RUN      ] LlvmLibcStrErrorTest.KnownErrors
[       OK ] LlvmLibcStrErrorTest.KnownErrors (78 us)
[ RUN      ] LlvmLibcStrErrorTest.UnknownErrors
[       OK ] LlvmLibcStrErrorTest.UnknownErrors (27 us)
Ran 2 tests.  PASS: 2  FAIL: 0
[1052/1202] Running unit test libc.test.src.string.strerror_r_test.__unit__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcStrErrorRTest.GnuVariantTests
[       OK ] LlvmLibcStrErrorRTest.GnuVariantTests (14 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[1053/1202] Running unit test libc.test.src.string.strlcat_test.__unit__
[==========] Running 3 tests from 1 test suite.
[ RUN      ] LlvmLibcStrlcatTest.TooBig
[       OK ] LlvmLibcStrlcatTest.TooBig (5 us)
[ RUN      ] LlvmLibcStrlcatTest.Smaller
[       OK ] LlvmLibcStrlcatTest.Smaller (2 us)
[ RUN      ] LlvmLibcStrlcatTest.No0
[       OK ] LlvmLibcStrlcatTest.No0 (1 us)
Ran 3 tests.  PASS: 3  FAIL: 0
[1054/1202] Running unit test libc.test.src.string.strlcpy_test.__unit__
[==========] Running 2 tests from 1 test suite.
[ RUN      ] LlvmLibcStrlcpyTest.TooBig
[       OK ] LlvmLibcStrlcpyTest.TooBig (6 us)
Step 7 (check-libc) failure: check-libc (failure)
...
[ RUN      ] LlvmLibcStrCSpnTest.ComplementarySpanShouldNotGoPastNullTerminator
[       OK ] LlvmLibcStrCSpnTest.ComplementarySpanShouldNotGoPastNullTerminator (4 us)
[ RUN      ] LlvmLibcStrCSpnTest.ComplementarySpanForEachIndividualCharacter
[       OK ] LlvmLibcStrCSpnTest.ComplementarySpanForEachIndividualCharacter (3 us)
[ RUN      ] LlvmLibcStrCSpnTest.ComplementarySpanIsStringLengthIfNoCharacterFound
[       OK ] LlvmLibcStrCSpnTest.ComplementarySpanIsStringLengthIfNoCharacterFound (2 us)
[ RUN      ] LlvmLibcStrCSpnTest.DuplicatedCharactersNotPartOfComplementarySpan
[       OK ] LlvmLibcStrCSpnTest.DuplicatedCharactersNotPartOfComplementarySpan (2 us)
Ran 4 tests.  PASS: 4  FAIL: 0
[1049/1202] Running unit test libc.test.src.stdio.vfscanf_test.__unit__
FAILED: libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.vfscanf_test.__unit__ /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-runtimes-build/build/runtimes/runtimes-bins/libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.vfscanf_test.__unit__ 
cd /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-runtimes-build/build/runtimes/runtimes-bins/libc/test/src/stdio && /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian/libc-x86_64-debian-dbg-runtimes-build/build/runtimes/runtimes-bins/libc/test/src/stdio/libc.test.src.stdio.vfscanf_test.__unit__.__build__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcFScanfTest.WriteToFile
Segmentation fault
[1050/1202] Running unit test libc.test.src.string.strdup_test.__unit__
[==========] Running 3 tests from 1 test suite.
[ RUN      ] LlvmLibcStrDupTest.EmptyString
[       OK ] LlvmLibcStrDupTest.EmptyString (7 us)
[ RUN      ] LlvmLibcStrDupTest.AnyString
[       OK ] LlvmLibcStrDupTest.AnyString (2 us)
[ RUN      ] LlvmLibcStrDupTest.NullPtr
[       OK ] LlvmLibcStrDupTest.NullPtr (2 us)
Ran 3 tests.  PASS: 3  FAIL: 0
[1051/1202] Running unit test libc.test.src.string.strerror_test.__unit__
[==========] Running 2 tests from 1 test suite.
[ RUN      ] LlvmLibcStrErrorTest.KnownErrors
[       OK ] LlvmLibcStrErrorTest.KnownErrors (78 us)
[ RUN      ] LlvmLibcStrErrorTest.UnknownErrors
[       OK ] LlvmLibcStrErrorTest.UnknownErrors (27 us)
Ran 2 tests.  PASS: 2  FAIL: 0
[1052/1202] Running unit test libc.test.src.string.strerror_r_test.__unit__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcStrErrorRTest.GnuVariantTests
[       OK ] LlvmLibcStrErrorRTest.GnuVariantTests (14 us)
Ran 1 tests.  PASS: 1  FAIL: 0
[1053/1202] Running unit test libc.test.src.string.strlcat_test.__unit__
[==========] Running 3 tests from 1 test suite.
[ RUN      ] LlvmLibcStrlcatTest.TooBig
[       OK ] LlvmLibcStrlcatTest.TooBig (5 us)
[ RUN      ] LlvmLibcStrlcatTest.Smaller
[       OK ] LlvmLibcStrlcatTest.Smaller (2 us)
[ RUN      ] LlvmLibcStrlcatTest.No0
[       OK ] LlvmLibcStrlcatTest.No0 (1 us)
Ran 3 tests.  PASS: 3  FAIL: 0
[1054/1202] Running unit test libc.test.src.string.strlcpy_test.__unit__
[==========] Running 2 tests from 1 test suite.
[ RUN      ] LlvmLibcStrlcpyTest.TooBig
[       OK ] LlvmLibcStrlcpyTest.TooBig (6 us)

5c4lar pushed a commit to 5c4lar/llvm-project that referenced this pull request Aug 29, 2024
@andreisfr @5c4lar
[Xtensa] Implement sextload i8 (llvm#106053)
54fe2ad
dmpolukhin pushed a commit to dmpolukhin/llvm-project that referenced this pull request Sep 2, 2024
@andreisfr @dmpolukhin
[Xtensa] Implement sextload i8 (llvm#106053)
bc659d9
@gerekon gerekon mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-barannikov s-barannikov s-barannikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreisfr @llvm-ci @s-barannikov @sstefan1