[DAGCombiner] Limit steps in shouldCombineToPostInc #116030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-selectiondag Author: Jonathan Cohen (jcohen-apple) ChangesCurrently the function will walk the entire DAG to find other candidates to perform a post-inc store. This leads to very long compilation times on large functions. Added a MaxSteps limit to avoid this, which is also aligned to how hasPredecessorHelper is used elsewhere in the code. Full diff: https://github.com/llvm/llvm-project/pull/116030.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index 6059229cd6d9a4..cc51aed40003f0 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -19089,7 +19089,8 @@ static bool shouldCombineToPostInc(SDNode *N, SDValue Ptr, SDNode *PtrUse,
IsMasked, OtherPtr, TLI)) {
SmallVector<const SDNode *, 2> Worklist;
Worklist.push_back(Use);
- if (SDNode::hasPredecessorHelper(N, Visited, Worklist))
+ constexpr unsigned int MaxSteps = 8192;
+ if (SDNode::hasPredecessorHelper(N, Visited, Worklist, MaxSteps))
return false;
}
}
|
arsenm
reviewed
Nov 13, 2024
| @@ -19089,7 +19089,8 @@ static bool shouldCombineToPostInc(SDNode *N, SDValue Ptr, SDNode *PtrUse, | |||
| IsMasked, OtherPtr, TLI)) { | |||
| SmallVector<const SDNode *, 2> Worklist; | |||
| Worklist.push_back(Use); | |||
| if (SDNode::hasPredecessorHelper(N, Visited, Worklist)) | |||
| constexpr unsigned int MaxSteps = 8192; | |||
There was a problem hiding this comment.
Big number to repeat multiple times. Move these to a common constant?
There was a problem hiding this comment.
I changed it to be a hidden cl option in case someone would like to play with it later, and defaulted to 8192. WDYT?
jcohen-apple
force-pushed
the
dev/jcohen/limit_steps_in_post_inc_combine
branch
2 times, most recently
from
4246b28 to
787ab75
Compare
arsenm
approved these changes
Nov 18, 2024
jcohen-apple
force-pushed
the
dev/jcohen/limit_steps_in_post_inc_combine
branch
3 times, most recently
from
6eadbbd to
2790a3d
Compare
Currently the function will walk the entire DAG to find other candidates to perform a post-inc store. This leads to very long compilation times on large functions. Added a MaxSteps limit to avoid this, which is also aligned to how hasPredecessorHelper is used elsewhere in the code.
jcohen-apple
force-pushed
the
dev/jcohen/limit_steps_in_post_inc_combine
branch
from
2790a3d to
79a709c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the function will walk the entire DAG to find other candidates to perform a post-inc store. This leads to very long compilation times on large functions. Added a MaxSteps limit to avoid this, which is also aligned to how hasPredecessorHelper is used elsewhere in the code.