[lldb][test] Disable inline_sites_live.cpp for non-Windows targets #116196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up for the conversation here llvm#115722. This test is designed for Windows target/PDB format, so it shouldn't be built and run for DWARF/etc.
|
@llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) ChangesThis is a follow-up for the conversation here This test is designed for Windows target/PDB format, so it shouldn't be built and run for DWARF/etc. Full diff: https://github.com/llvm/llvm-project/pull/116196.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp b/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp
index 549bc881b19bb7..906f3d7dff0a56 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp
@@ -1,5 +1,5 @@
// clang-format off
-// REQUIRES: system-windows
+// REQUIRES: target-windows
// RUN: %build -o %t.exe -- %s
// RUN: %lldb -f %t.exe -s \
|
labath
approved these changes
Nov 14, 2024
akshayrdeodhar
pushed a commit
to akshayrdeodhar/llvm-project
that referenced
this pull request
Nov 18, 2024
…lvm#116196) This is a follow-up for the conversation here llvm#115722. This test is designed for Windows target/PDB format, so it shouldn't be built and run for DWARF/etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for the conversation here
#115722.
This test is designed for Windows target/PDB format, so it shouldn't be built and run for DWARF/etc.