Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][FIX] Adjust test to be non-flaky #122331

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jdoerfert
Copy link
Member

The test runs asynchronous kernels and depending on the timing the output is slightly different. We now only check for the common parts of the output.

The test runs asynchronous kernels and depending on the timing the
output is slightly different. We now only check for the common parts of
the output.
@llvmbot
Copy link
Member

llvmbot commented Jan 9, 2025

@llvm/pr-subscribers-offload

Author: Johannes Doerfert (jdoerfert)

Changes

The test runs asynchronous kernels and depending on the timing the output is slightly different. We now only check for the common parts of the output.


Full diff: https://github.com/llvm/llvm-project/pull/122331.diff

1 Files Affected:

  • (modified) offload/test/sanitizer/kernel_crash_async.c (+1-1)
diff --git a/offload/test/sanitizer/kernel_crash_async.c b/offload/test/sanitizer/kernel_crash_async.c
index ee22ba504018be..d51418f8178897 100644
--- a/offload/test/sanitizer/kernel_crash_async.c
+++ b/offload/test/sanitizer/kernel_crash_async.c
@@ -36,4 +36,4 @@ int main(void) {
 // TRACE: Kernel {{.*}} (__omp_offloading_{{.*}}_main_l29)
 // TRACE:     launchKernel
 //
-// CHECK: Kernel {{[0-9]}}: {{.*}} (__omp_offloading_{{.*}}_main_l29)
+// CHECK: Kernel {{.*}} (__omp_offloading_{{.*}}_main_l29)

@jdoerfert jdoerfert merged commit 1739ba9 into llvm:main Jan 9, 2025
8 checks passed
@jdoerfert jdoerfert deleted the offload-flaky-test branch January 9, 2025 19:57
BaiXilin pushed a commit to BaiXilin/llvm-fix-vnni-instr-types that referenced this pull request Jan 12, 2025
The test runs asynchronous kernels and depending on the timing the
output is slightly different. We now only check for the common parts of
the output.
Mel-Chen pushed a commit to Mel-Chen/llvm-project that referenced this pull request Jan 13, 2025
The test runs asynchronous kernels and depending on the timing the
output is slightly different. We now only check for the common parts of
the output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants