libclc: Stop using asm declarations for r600 on amdgcn for get_global_size #128692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_size Comparing the case where each dimension is used alone, the only codegen difference is a missed addressing mode fold for the constant offset in the old version due to an ancient bug.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Actually the old codegen looks totally busted, loading from a constant offset from null |
frasercrmck
approved these changes
Feb 25, 2025
arsenm
deleted the
users/arsenm/libclc/amdgcn-stop-using-r600-asm-intrinsic-declarations-get-global-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the case where each dimension is used alone, the only codegen difference
is a missed addressing mode fold for the constant offset in the old version due to
an ancient bug.