[mlir][llvm] Add icmp folder #65343
Merged
[mlir][llvm] Add icmp folder #65343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This revision adds a simple icmp folder that performs the following folds to the LLVM dialect icmp op: - cmpi(eq/ne, x, x) -> true/false - cmpi(eq/ne, alloca, null) -> false/true - cmpi(eq/ne, null, alloca) -> cmpi(eq/ne, alloca, null)
|
Looks good! Since you've gone through the effort of making this work with vector types as well, could you add at least one test that uses vector input types? |
and update constant materialization to support vectors.
|
Good point, the constant materialization did indeed not support vectors! |
zero9178
approved these changes
Sep 5, 2023
| /// Returns a scalar or vector boolean attribute of the given type. | ||
| static Attribute getBoolAttribute(Type type, MLIRContext *ctx, bool value) { | ||
| auto boolAttr = BoolAttr::get(ctx, value); | ||
| ShapedType shapedType = llvm::dyn_cast_or_null<ShapedType>(type); |
There was a problem hiding this comment.
Suggested change
| ShapedType shapedType = llvm::dyn_cast_or_null<ShapedType>(type); | |
| ShapedType shapedType = dyn_cast<ShapedType>(type); |
|
Please don't use subscribers teams to request reviews |
Could you elaborate what you mean? These are added automatically as they are code-owners of changed files. Isn't the intent of these teams being code-owners that they are automatically added as reviewers and members therefore notified? |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
This revision adds a simple icmp folder that performs the following folds to the LLVM dialect icmp op: - cmpi(eq/ne, x, x) -> true/false - cmpi(eq/ne, alloca, null) -> false/true - cmpi(eq/ne, null, alloca) -> cmpi(eq/ne, alloca, null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision adds a simple icmp folder that performs the following folds to the LLVM dialect icmp op: