Reland "[CUDA][HIP] Fix overloading resolution in global var init" #65606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
clang:frontend
Artem-B
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM.
I'm still figuring out the github-based workflow. One thing that may be useful in the future
would be to start the pull request branch with the original/reverted commit and put the updates into separate commits, so one could see incremental changes, similar to what phabricator's "history" was providing.
|
Please reflow the title to avoid the |
yxsamliu
changed the title
https://reviews.llvm.org/D158247 caused regressions for HIP on Windows and was reverted. A reduced test case is: ``` typedef void (__stdcall* funcTy)(); void invoke(funcTy f); static void __stdcall callee() noexcept { } void foo() { invoke(callee); } ``` It is due to clang missing handling host/device attributes for calling convention at a few places This patch fixes that.
yxsamliu
force-pushed
the
fix-global-init5
branch
from
c98f58c to
a998f12
Compare
MaskRay
reviewed
Sep 8, 2023
| @@ -70,3 +70,4 @@ pythonenv* | |||
| /clang/utils/analyzer/projects/*/RefScanBuildResults | |||
| # automodapi puts generated documentation files here. | |||
| /lldb/docs/python_api/ | |||
| /Debug/ | |||
There was a problem hiding this comment.
This seems accidental? I removed it in 994bdce
(Personally I place build directories in /tmp to prevent mistakes..)
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 13, 2023
…lvm#65606) Cherry-pick 9b77638 https://reviews.llvm.org/D158247 caused regressions for HIP on Windows and was reverted. A reduced test case is: ``` typedef void (__stdcall* funcTy)(); void invoke(funcTy f); static void __stdcall callee() noexcept { } void foo() { invoke(callee); } ``` It is due to clang missing handling host/device attributes for calling convention at a few places This patch fixes that. Change-Id: Ibbc5cbe232d73ddaeb91f13f6afbff3151c9bf0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reviews.llvm.org/D158247 caused regressions for HIP on Windows and was reverted.
A reduced test case is:
It is due to clang missing handling host/device attributes for calling convention at a few places
This patch fixes that.