[AArch64][Clang] Implement ACLE rintn intrinsics #66112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
davemgreen
reviewed
Sep 13, 2023
|
Just a nit, but please add a tag to the commit message, like "[Clang][AArch64]". |
Change-Id: I7f05a59f07f05ff8ac84cbab59a7803f1fe1642f
Change-Id: Ibfe830cf69e3ea10f68f651e5a5d507769792496
|
Thank you both for your comments. I've simplified the patch by using the llvm intrinsic that you suggested David, thanks! In trying to fix the commit message, I messed up my git history, hence the force-pushes above to try to fix it. Hopefully the couple of commits make sense. In retrospect, I should have used |
Blue-Dot
changed the title
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Sep 14, 2023
This patch adds support for two missing ACLE intrinsics for floating point round with ties to even: - rintn - rintnf These are specified in ACLE section 8.6: [https://arm-software.github.io/acle/main/acle.html#floating-point-data-processing-intrinsics]
This was referenced Sep 14, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
This patch adds support for two missing ACLE intrinsics for floating point round with ties to even: - rintn - rintnf These are specified in ACLE section 8.6: [https://arm-software.github.io/acle/main/acle.html#floating-point-data-processing-intrinsics]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for two missing ACLE intrinsics for floating point round with ties to even:
These are specified in ACLE section 8.6: [https://arm-software.github.io/acle/main/acle.html#floating-point-data-processing-intrinsics]
Change-Id: I951971ad5a3fd3822efdf8cbae22918c31eef28a