[clang] Improve CI output when trailing whitespace is found

[ldionne]

Fixes #66468

[ldionne]

@asl This should make it a bit more explicit. I see this now when running locally:

+ echo '*** Checking for trailing whitespace left in Clang source files ***'
*** Checking for trailing whitespace left in Clang source files ***
+ grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs
clang/include/clang-c/Index.h:38:
+ echo '*** Trailing whitespace has been found in Clang source files as described above ***'
*** Trailing whitespace has been found in Clang source files as described above ***
+ exit 1

WDYT? It's still a bit cluttered by the fact that we run with set -x but I think it might be good enough.

[llvmbot]

@llvm/pr-subscribers-clang

Changes

Fixes #66468

Full diff: https://github.com/llvm/llvm-project/pull/66649.diff

1 Files Affected:

• (modified) clang/utils/ci/run-buildbot (+5-1)

diff --git a/clang/utils/ci/run-buildbot b/clang/utils/ci/run-buildbot
index d117fccc7e3fbd8..f47ffb5cbd38dcd 100755
--- a/clang/utils/ci/run-buildbot
+++ b/clang/utils/ci/run-buildbot
@@ -70,7 +70,11 @@ ninja --version
 
 case "${BUILDER}" in
 check-format)
-    ! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs
+    echo "*** Checking for trailing whitespace left in Clang source files ***"
+    if grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs; then
+        echo "*** Trailing whitespace has been found in Clang source files as described above ***"
+        exit 1
+    fi
 ;;
 build-clang)
     mkdir install