Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMDGPU] Add gfx1150 SALU Float instructions #66884

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[AMDGPU] Add gfx1150 SALU Float instructions #66884

merged 1 commit into from
Sep 21, 2023

Conversation

mbrkusanin
Copy link
Collaborator

No description provided.

@llvmbot llvmbot added backend:AMDGPU mc Machine (object) code labels Sep 20, 2023
@jayfoad jayfoad requested a review from a team September 20, 2023 10:36
@mbrkusanin mbrkusanin mentioned this pull request Sep 20, 2023
Merged
@jayfoad
Copy link
Contributor

jayfoad commented Sep 20, 2023

This is just the MC layer (assembler/disassembler) support, right? LGTM but we should allow some time for others to review it.

@mbrkusanin
Copy link
Collaborator Author

This is just the MC layer (assembler/disassembler) support, right? LGTM but we should allow some time for others to review it.

Correct. #66885 contains codegen parts.

@mbrkusanin mbrkusanin merged commit 923285b into llvm:main Sep 21, 2023
@mbrkusanin mbrkusanin deleted the salu-float branch September 21, 2023 09:22
@kstoimenov kstoimenov mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayfoad jayfoad jayfoad left review comments

@rampitec rampitec rampitec approved these changes

@arsenm arsenm Awaiting requested review from arsenm

@Sisyph Sisyph Awaiting requested review from Sisyph

Assignees
No one assigned
Labels
backend:AMDGPU mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrkusanin @jayfoad @rampitec @llvmbot