[lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

[kastiglione]

std::basic_string<char> is not a regex, and treating it as such could unintentionally
cause a formatter to substring match a template type parameter, for example:
std::vector<std::basic_string<char>>.

Differential Revision: https://reviews.llvm.org/D158663

[llvmbot]

@llvm/pr-subscribers-lldb

Changes

std::basic_string<char> is not a regex, and treating it as such could unintentionally
cause a formatter to substring match a template type parameter, for example:
std::vector<std::basic_string<char>>.

Differential Revision: https://reviews.llvm.org/D158663

---

Full diff: https://github.com/llvm/llvm-project/pull/66949.diff

1 Files Affected:

• (modified) lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp (+1-1)

diff --git a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
index 3d709e3d6759556..c1743a5e0a418dd 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
@@ -1009,7 +1009,7 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
   cpp_category_sp->AddTypeSummary("std::string", eFormatterMatchExact,
                                   std_string_summary_sp);
   cpp_category_sp->AddTypeSummary("std::basic_string<char>",
-                                  eFormatterMatchRegex, std_string_summary_sp);
+                                  eFormatterMatchExact, std_string_summary_sp);
   cpp_category_sp->AddTypeSummary(
       "std::basic_string<char,std::char_traits<char>,std::allocator<char> >",
       eFormatterMatchExact, std_string_summary_sp);

[walter-erquinigo]

Good catch! I think I have suffered because of this at some point.

[jimingham]

In this case, it's clearly not a regex, so this change is fine. But ALSO, any regex matches against std types should be `^std::whatever` and not just `std::whatever` to avoid this sort of unintended matching. Jim

…

On Sep 20, 2023, at 1:37 PM, Walter Erquinigo ***@***.***> wrote: @walter-erquinigo approved this pull request. Good catch! I think I have suffered because of this at some point. — Reply to this email directly, view it on GitHub <#66949 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVWY4RBH5JH3GUIU6IUTX3NHYFANCNFSM6AAAAAA5APBMII>. You are receiving this because your review was requested.