Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attr docs from previous no-unique-adderss change #67195

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

amykhuang
Copy link
Collaborator

@amykhuang amykhuang commented Sep 22, 2023

Previous change in #65675 broke the docs generation.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 22, 2023
@amykhuang amykhuang merged commit 44f2db7 into llvm:main Sep 22, 2023
@llvmbot
Copy link
Member

llvmbot commented Sep 22, 2023

@llvm/pr-subscribers-clang

Changes

Previous change in #65675 broke the docs generation.


Full diff: https://github.com/llvm/llvm-project/pull/67195.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/Attr.td (-1)
diff --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td
index bb8d204f33dc531..35eb6ff63132629 100644
--- a/clang/include/clang/Basic/Attr.td
+++ b/clang/include/clang/Basic/Attr.td
@@ -1803,7 +1803,6 @@ def NoUniqueAddress : InheritableAttr {
   // No spellings because instances of this attribute are created by
   // MSNoUniqueAddress and ItaniumNoUniqueAddress
   let Spellings = [];
-  let Documentation = [NoUniqueAddressDocs];
 }
 
 def MSNoUniqueAddress : InheritableAttr, TargetSpecificAttr<TargetMicrosoftCXXABI> {

MaskRay added a commit that referenced this pull request Sep 22, 2023
This reverts commit 44f2db7.

It caused
```
error: Record `NoUniqueAddress', field `Documentation' exists but does not have a list value
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants