Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tli nfc fix mechanism propagating mangled names for tli function mappings ac3 #67308

Conversation

JolantaJensen
Copy link
Contributor

No description provided.

@JolantaJensen JolantaJensen force-pushed the TLI-NFC-Fix-mechanism-propagating-mangled-names-for-TLI-function-mappings-AC3 branch from a29ddf9 to 6abc65f Compare October 3, 2023 14:07
Copy link
Contributor

@mgabka mgabka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message looks like a copy&paste of commit message from the other patch, with just one extra sentence at the end.
Could you simplify it? There is no need to repeat it.

When "s" is used as the ISA name, the compiler can make decisions
specific for SVE, based on VFABI specification.

This patch replaces _LLLVM_ ISA in TLI mappings with "s"
in the SVE specific (scalar to vector routine) mappings.
@JolantaJensen JolantaJensen force-pushed the TLI-NFC-Fix-mechanism-propagating-mangled-names-for-TLI-function-mappings-AC3 branch from 6abc65f to c86d606 Compare October 3, 2023 16:03
@JolantaJensen JolantaJensen merged commit f71781c into llvm:main Oct 5, 2023
JolantaJensen added a commit to JolantaJensen/jjensen-llvm-project that referenced this pull request Oct 5, 2023
…ed names

        and the call's argument types to construct the VFInfo.

Currently the tryDemangleForVFABI is incorrectly making assumptions that when
the mangled name has __LLVM__ set as ISA and _vlen_ is set to scalable/VLA
the module can be queried to identify the correct VF. This works currently only
by chance rather than by design and limits the ability to maximise the use for
the Vector ABI. This behaviour is changed by
llvm#66656 and
llvm#67308
and means demangling can be implemented as expected based solely on the rules
as documented within the VFABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants