[clang] Enable Wenum-constexpr-conversion also in system headers and …

[carlosgalvezp]

…macros

As per review comments on https://reviews.llvm.org/D150226, we should allow for one more release before turning this warning into a hard error, by making it visible in system headers and macros, so that people are aware of it and can work on it.

[llvmbot]

@llvm/pr-subscribers-clang

Changes

…macros

As per review comments on https://reviews.llvm.org/D150226, we should allow for one more release before turning this warning into a hard error, by making it visible in system headers and macros, so that people are aware of it and can work on it.

---

Full diff: https://github.com/llvm/llvm-project/pull/67528.diff

2 Files Affected:

• (modified) clang/docs/ReleaseNotes.rst (+3)
• (modified) clang/include/clang/Basic/DiagnosticASTKinds.td (+2-1)

diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 477a40630f11097..3b6cfa776c85e46 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -67,6 +67,9 @@ C++ Specific Potentially Breaking Changes
   (`#49884 <https://github.com/llvm/llvm-project/issues/49884>`_), and
   (`#61273 <https://github.com/llvm/llvm-project/issues/61273>`_)
 
+- The warning `-Wenum-constexpr-conversion` is now also enabled by default on system headers and
+  macros. It will be turned into a hard (non-downgradable) error in the next Clang release.
+
 ABI Changes in This Version
 ---------------------------
 - Following the SystemV ABI for x86-64, ``__int128`` arguments will no longer
diff --git a/clang/include/clang/Basic/DiagnosticASTKinds.td b/clang/include/clang/Basic/DiagnosticASTKinds.td
index d2656310e79c9b8..0019553233fdef6 100644
--- a/clang/include/clang/Basic/DiagnosticASTKinds.td
+++ b/clang/include/clang/Basic/DiagnosticASTKinds.td
@@ -405,7 +405,8 @@ def warn_fixedpoint_constant_overflow : Warning<
   InGroup<DiagGroup<"fixed-point-overflow">>;
 def warn_constexpr_unscoped_enum_out_of_range : Warning<
   "integer value %0 is outside the valid range of values [%1, %2] for the "
-  "enumeration type %3">, DefaultError, InGroup<DiagGroup<"enum-constexpr-conversion">>;
+  "enumeration type %3">, DefaultError, ShowInSystemHeader, ShowInSystemMacro,
+  InGroup<DiagGroup<"enum-constexpr-conversion">>;
 
 // This is a temporary diagnostic, and shall be removed once our
 // implementation is complete, and like the preceding constexpr notes belongs

[carlosgalvezp]

I would need some help with the failing pre-merge test, I don't really understand why that failure would be related to this patch...

/var/lib/buildkite-agent/builds/linux-56-7f758798dd-v9p4k-1/llvm-project/clang-ci/clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp:111: Failure
--
  | Value of: Actual
  | Expected: is equal to "((Y & V2) \| (X \| V3))"
  | Actual: "((Y & V3) \| (X \| V2))"

Pinging @gribozavr @ymand @sgatev as Code Owners for the Analysis folder, does the above error signature look familiar/related to this change? Thanks!

[carlosgalvezp]

It seems checks are broken on trunk, I see commits merged with failing pre-merge tests. They seem to be unrelated to this patch though.

Is there anything else you'd like fixed before merging? @dwblaikie @AaronBallman @shafik

[dwblaikie]

It seems checks are broken on trunk, I see commits merged with failing pre-merge tests. They seem to be unrelated to this patch though.

Is there anything else you'd like fixed before merging? @dwblaikie @AaronBallman @shafik

Nothing further from me, at least. But maybe wait for approval from one of the other two.

[carlosgalvezp]

Friendly ping @AaronBallman @shafik

[AaronBallman]

LGTM!

[smeenai]

boostorg/mpl#69 is still a problem, unfortunately.

[shafik]

Thank you for doing this work.