Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir] Change the class name of the GenerateWarpgroupDescriptor #68286

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[mlir] Change the class name of the GenerateWarpgroupDescriptor #68286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/NVGPU/IR/NVGPU.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ def NVGPU_TmaCreateDescriptorOp : NVGPU_Op<"tma.create.descriptor", []> {
let hasVerifier = 1;
}

def NVGPU_GenerateWarpgroupDescriptorOp : NVGPU_Op<"warpgroup.generate.descriptor", []> {
def NVGPU_WarpgroupGenerateDescriptorOp : NVGPU_Op<"warpgroup.generate.descriptor", []> {
let summary = "Generate a warpgroup matrix descriptor";
let description = [{
This Op builds a `nvgpu.warpgroup.descriptor` that is used by
Expand Down
6 changes: 3 additions & 3 deletions mlir/lib/Conversion/NVGPUToNVVM/NVGPUToNVVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,12 +968,12 @@ struct NVGPUTmaAsyncLoadOpLowering
}
};
struct NVGPUGenerateWarpgroupDescriptorLowering
: public ConvertOpToLLVMPattern<nvgpu::GenerateWarpgroupDescriptorOp> {
: public ConvertOpToLLVMPattern<nvgpu::WarpgroupGenerateDescriptorOp> {
using ConvertOpToLLVMPattern<
nvgpu::GenerateWarpgroupDescriptorOp>::ConvertOpToLLVMPattern;
nvgpu::WarpgroupGenerateDescriptorOp>::ConvertOpToLLVMPattern;

LogicalResult
matchAndRewrite(nvgpu::GenerateWarpgroupDescriptorOp op, OpAdaptor adaptor,
matchAndRewrite(nvgpu::WarpgroupGenerateDescriptorOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override {

ImplicitLocOpBuilder b(op->getLoc(), rewriter);
Expand Down
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,10 @@ LogicalResult TmaCreateDescriptorOp::verify() {
}

//===----------------------------------------------------------------------===//
// NVGPU_GenerateWarpgroupDescriptorOp
// NVGPU_WarpgroupGenerateDescriptorOp
//===----------------------------------------------------------------------===//

LogicalResult GenerateWarpgroupDescriptorOp::verify() {
LogicalResult WarpgroupGenerateDescriptorOp::verify() {
MemRefType memrefType = getTensor().getType();
MemRefType tensorMapType = getTensorMap().getType().getTensor();

Expand Down