[AArch64][GlobalISel] Add legalization for G_VECREDUCE_MUL #68398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
chuongg3
force-pushed
the
GlobalISel_VECREDUCE_MUL
branch
from
1e6e59f to
c75c915
Compare
davemgreen
reviewed
Oct 6, 2023
|
Good style: state legal types before clamping and give a mir test as you touched the legaliser. |
davemgreen
reviewed
Oct 10, 2023
| ; RUN: llc -mtriple=aarch64 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-SD | ||
| ; RUN: llc -mtriple=aarch64 -global-isel -global-isel-abort=2 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-GI | ||
|
|
||
| ; CHECK_GI: warning: Instruction selection used fallback path for mulv_v3i62 |
| @@ -885,6 +885,14 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST) | |||
| .clampMaxNumElements(1, s16, 8) | |||
| .lower(); | |||
|
|
|||
| getActionDefinitionsBuilder(G_VECREDUCE_MUL) | |||
| .clampMaxNumElements(1, s64, 1) | |||
There was a problem hiding this comment.
For i64 a max clamp of 1 is the same as scalarizing, and this line could be omitted.
chuongg3
force-pushed
the
GlobalISel_VECREDUCE_MUL
branch
from
91452b5 to
47d44c9
Compare
davemgreen
approved these changes
Oct 16, 2023
chuongg3
force-pushed
the
GlobalISel_VECREDUCE_MUL
branch
from
47d44c9 to
ace4b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.