Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][DWARFASTParserClang][NFC] Fix comment regarding static data member detection #68405

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[lldb][DWARFASTParserClang][NFC] Fix comment regarding static data member detection #68405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2878,8 +2878,8 @@ void DWARFASTParserClang::ParseSingleMember(
attrs.accessibility = eAccessNone;

// Handle static members, which are typically members without
// locations. However, GCC *never* emits DW_AT_data_member_location
// for static data members of unions.
// locations. However, GCC doesn't emit DW_AT_data_member_location
// for any union members (regardless of linkage).
// Non-normative text pre-DWARFv5 recommends marking static
// data members with an DW_AT_external flag. Clang emits this consistently
// whereas GCC emits it only for static data members if not part of an
Expand Down