[YAMLTraits] Fix std::optional input on empty documents #68947
Merged
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input document is non-empty,
mapOptional
works as expected, settingstd::optional
tostd::nullopt
when the field is not present. When the input document is empty, we hit a special case inside ofInput::preflightKey
that results inUseDefault = false
, which results in thestd::optional
erroneously being set to a non-nullopt value.preflightKey
is changed to setUseDefault = true
in this case to make the behavior consistent between empty and non-empty documents.