[Libomptarget] Make the references to 'malloc' and 'free' weak. #69356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We use `malloc` internally in the DeviceRTL to handle data globalization. If this is undefined it will map to the Nvidia implementation of `malloc` for NVPTX and return `nullptr` for AMDGPU. This is somewhat problematic, because when using this as a shared library it causes us to always extract the GPU libc implementation, which uses RPC and thus requires an RPC server. Making this `weak` allows us to implement this internally without worrying about binding to the GPU `libc` implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We use
mallocinternally in the DeviceRTL to handle dataglobalization. If this is undefined it will map to the Nvidia
implementation of
mallocfor NVPTX and returnnullptrfor AMDGPU.This is somewhat problematic, because when using this as a shared
library it causes us to always extract the GPU libc implementation,
which uses RPC and thus requires an RPC server. Making this
weakallows us to implement this internally without worrying about binding to
the GPU
libcimplementation.