Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU] Do not preserve UniformityInfo #76696

Merged
merged 3 commits into from
Jan 2, 2024
Merged

[AMDGPU] Do not preserve UniformityInfo #76696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7806a54
[AMDGPU] Do not preserve UniformityInfo
ssahasra Dec 23, 2023
f235ba1
add generic note about not preserving uniformity analysis
ssahasra Jan 2, 2024
a553f20
minor fix in comment: "updation"
ssahasra Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/include/llvm/ADT/GenericUniformityImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@
/// the propagation of the impact of divergent control flow on the divergence of
/// values (sync dependencies).
///
/// NOTE: In general, no interface exists for a transform to update
/// (Machine)UniformityInfo. Additionally, (Machine)CycleAnalysis is a
/// transitive dependence, but it also does not provide an interface for
/// updation. Given that, transforms should not preserve uniformity in their
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"updation" should be updating?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"updation" should be a word! :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had looked it up ... "updation" is a word, and it's use as a noun is not wrong here. "updating" requires an object after it. But it was not clear to me if the verb "updating" is preferred over the noun "updation" in general ... so went with @arsenm's preference, writing it off as an ESL thing, and/or a tussle between en_US, en_UK and en_IN :)

/// getAnalysisUsage() callback.
///
//===----------------------------------------------------------------------===//

#ifndef LLVM_ADT_GENERICUNIFORMITYIMPL_H
Expand Down