[Github] Make issue write workflow only run after success/failure #97341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the issue write workflow only run after success or failure of the workflow invoking it, preventing it from running where the original workflow was skipped. Fixes llvm#97294
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch makes the issue write workflow only run after success or failure of the workflow invoking it, preventing it from running where the original workflow was skipped. Fixes #97294 Full diff: https://github.com/llvm/llvm-project/pull/97341.diff 1 Files Affected:
diff --git a/.github/workflows/issue-write.yml b/.github/workflows/issue-write.yml
index 616b323ad5fac..d4814a2fe9014 100644
--- a/.github/workflows/issue-write.yml
+++ b/.github/workflows/issue-write.yml
@@ -18,7 +18,11 @@ jobs:
permissions:
pull-requests: write
if: >
- github.event.workflow_run.event == 'pull_request'
+ github.event.workflow_run.event == 'pull_request' &&
+ (
+ github.event.workflow_run.conclusion == 'success' ||
+ github.event.workflow_run.conclusion == 'failure'
+ )
steps:
- name: 'Download artifact'
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
|
|
Sounds good. I'll get to reviewing that one in a bit. |
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
…vm#97341) This patch makes the issue write workflow only run after success or failure of the workflow invoking it, preventing it from running where the original workflow was skipped. Fixes llvm#97294
kbluck
pushed a commit
to kbluck/llvm-project
that referenced
this pull request
Jul 6, 2024
…vm#97341) This patch makes the issue write workflow only run after success or failure of the workflow invoking it, preventing it from running where the original workflow was skipped. Fixes llvm#97294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the issue write workflow only run after success or failure of the workflow invoking it, preventing it from running where the original workflow was skipped.
Fixes #97294