Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two commands #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add two commands #35

wants to merge 2 commits into from

Conversation

Anaphory
Copy link

@Anaphory Anaphory commented Mar 9, 2020

phyltr problematic: For binary trees – inspired by DensiTree complaining about some non-binary trees

phyltr sort: Takes an ordered list of taxa and tries to represent that order in the tree. In order for it to work as intended, the read_taxa probably needs to be refactored. Could it maybe be allowed to return a list instead of a set? Currently, my way to use sort with a file is with `cat file`…

@lmaurits
Copy link
Owner

I wonder if a binarise command, which replaces multifurcations with binary splits and length-zero branches, is a more elegant solution to the Densitree problem? Although I'm not opposed to a command which rejects trees with particular undesirable properties, if we can think of more of these? I initially thought "I don't like the name problematic, we should call it phyltr!", but then realised phyltr filter is asking for confusion.

Do I understand correctly, that the sort command simply attempts to swap left and right children at branch points without changing topology, to maximise similarity to a desired ordering of leaves?

@Anaphory
Copy link
Author

Anaphory commented Mar 13, 2020 via email

@Anaphory
Copy link
Author

True, tests for these commands would be useful. How does one write phyltr tests again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants