Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace facebook/webdriver with php-webdriver/webdriver #251

Merged
merged 1 commit into from
Jan 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Steward is a set of libraries made to simplify writing and running robust functi
- produces test results in JUnit format (easily processable, for example, by Jenkins and other tools)
- and more...
- Tests are run in parallel, so the only bottleneck is the number of Selenium nodes you start simultaneously.
- Simple syntax sugar layer on top of default [WebDriver commands](https://github.com/facebook/php-webdriver/wiki/Example-command-reference) helps shorten your tests and improve readability.
- Simple syntax sugar layer on top of default [WebDriver commands](https://github.com/php-webdriver/php-webdriver/wiki/Example-command-reference) helps shorten your tests and improve readability.
- If you already use PHP, you don't have to learn a new language to write functional tests. Moreover, if you are familiar with unit tests and PHPUnit, you know it all.
- Allows you to plan test dependencies.
- For example, if you need to wait 2 minutes until some event gets through your message queue before testing the result? No problem! The order of tests is optimized to minimize the total execution time.
Expand All @@ -29,7 +29,7 @@ Steward is a set of libraries made to simplify writing and running robust functi
- Cloud services like [Sauce Labs](https://saucelabs.com/), [BrowserStack](https://www.browserstack.com/) or [TestingBot](https://testingbot.com/) are fully integrated giving you a chance to run tests with less setup and without your own infrastructure.
- Steward is field tested - we use it daily in [our company](https://www.lmc.eu/english) to maintain the quality of our products thanks to hundreds of test-cases. The library itself is also extensively covered by unit tests.
- Steward is built on solid foundations: [WebDriver](http://www.w3.org/TR/webdriver/) is W3C draft standard for browser automation,
[php-webdriver](https://github.com/facebook/php-webdriver) is the most used and developed Selenium language binding for PHP,
[php-webdriver](https://github.com/php-webdriver/php-webdriver) is the most used and developed Selenium language binding for PHP,
[PHPUnit](https://phpunit.de/) is a well known and widely used testing framework, and
[Symfony Console](http://symfony.com/doc/current/components/console.html) is industry standard for PHP CLI applications.

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"beberlei/assert": "^3.0",
"clue/graph": "~0.9.0",
"doctrine/inflector": "~1.0",
"facebook/webdriver": "dev-community@dev",
"php-webdriver/webdriver": "dev-community@dev",
"florianwolters/component-util-singleton": "0.3.2",
"graphp/algorithms": "^0.8.1",
"nette/reflection": "^2.4.2",
Expand Down
2 changes: 1 addition & 1 deletion src/Selenium/CapabilitiesResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ protected function setupFirefoxCapabilities(DesiredCapabilities $capabilities):
// Firefox does not (as a intended feature) trigger "change" and "focus" events in javascript if not in active
// (focused) window. This would be a problem for concurrent testing - solution is to use focusmanager.testmode.
// See https://code.google.com/p/selenium/issues/detail?id=157
$profile = new FirefoxProfile(); // see https://github.com/facebook/php-webdriver/wiki/FirefoxProfile
$profile = new FirefoxProfile(); // see https://github.com/php-webdriver/php-webdriver/wiki/FirefoxProfile
$profile->setPreference('focusmanager.testmode', true);

$capabilities->setCapability(FirefoxDriver::PROFILE, $profile);
Expand Down
2 changes: 1 addition & 1 deletion src/Test/AbstractTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function debug(string $format, ...$args): void
* Sleep for given amount of seconds. Unlike sleep(), also the float values are supported.
* ALWAYS TRY TO USE WAIT() AND EXPLICIT WAITS INSTEAD!
*
* @see https://github.com/facebook/php-webdriver/wiki/HowTo-Wait
* @see https://github.com/php-webdriver/php-webdriver/wiki/HowTo-Wait
*/
public static function sleep(float $seconds): void
{
Expand Down