Prohibit tests in beforeEach etc. hook calls #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... As well as nested hook calls.
|
Hi @papandreou and thanks for your contribution. Regarding the error message it would be of course much better if the message could explain the actual problem as precisely as possible. |
…introduce bogus helper functions
|
Hey @lo1tuma, thanks for the feedback. I've updated the PR so that separate error messages are issued, when it's a test nested within a hook, or a hook within a hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick implementation to see if there's any interest. And yes, this actually happened :)
Questions:
Unexpected test nested within a beforeEach hook.rather thanUnexpected test nested within another test.?