Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add article about Django timeout #73

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Add article about Django timeout #73

merged 6 commits into from
Dec 8, 2022

Conversation

umluizlima
Copy link
Contributor

@umluizlima umluizlima commented Nov 2, 2022 •
edited
Loading

@umluizlima umluizlima added the enhancement New feature or request label Nov 2, 2022
@umluizlima umluizlima self-assigned this Nov 2, 2022
@netlify
Copy link

netlify bot commented Nov 2, 2022 •
edited
Loading

✅ Deploy Preview for loadsmart-engineering ready!

Name Link
🔨 Latest commit 4806467
🔍 Latest deploy log https://app.netlify.com/sites/loadsmart-engineering/deploys/63924f6d3fda110008077fd9
😎 Deploy Preview https://deploy-preview-73--loadsmart-engineering.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

umluizlima
umluizlima commented Nov 2, 2022
View reviewed changes
content/posts/2022-11-02-how-to-fix-django-admin-timeouts/index.md

Have you ever noticed some Django admin page taking a long time to load? Maybe even ending in a timeout (http 504)?

![Example](./example.png)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image copied from: https://docs.djangoproject.com/en/4.1/ref/contrib/admin/#django.contrib.admin.ModelAdmin.fieldsets

@umluizlima umluizlima marked this pull request as ready for review November 2, 2022 19:00
rcmachado
rcmachado reviewed Nov 9, 2022
View reviewed changes
Copy link
Member

@rcmachado rcmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever and useful tips for anyone working with Django.

I left some suggestions regarding the usage of links. Also, I would recommend having a native English speaker review it, as English is not our first language.

content/posts/2022-11-02-how-to-fix-django-admin-timeouts/index.md Outdated Show resolved Hide resolved
content/posts/2022-11-02-how-to-fix-django-admin-timeouts/index.md Outdated Show resolved Hide resolved
content/posts/2022-11-02-how-to-fix-django-admin-timeouts/index.md Outdated Show resolved Hide resolved
@rcmachado rcmachado requested a review from barbosa November 9, 2022 17:19
@umluizlima
Copy link
Contributor Author

Clever and useful tips for anyone working with Django.

I left some suggestions regarding the usage of links. Also, I would recommend having a native English speaker review it, as English is not our first language.

Thanks for the suggestions, @rcmachado !

alexantoniomoran
alexantoniomoran approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@alexantoniomoran alexantoniomoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've run into this problem a few times- nice to have a centralized article for it 👍

content/posts/2022-11-02-how-to-fix-django-admin-timeouts/index.md Outdated Show resolved Hide resolved
content/posts/2022-11-02-how-to-fix-django-admin-timeouts/index.md Outdated Show resolved Hide resolved
@umluizlima umluizlima requested a review from rcmachado December 6, 2022 21:23
rcmachado
rcmachado approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@rcmachado rcmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution, @umluizlima!

@umluizlima umluizlima merged commit a23e499 into main Dec 8, 2022
@umluizlima umluizlima deleted the sgoe-add-django-timeout-post branch December 8, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmachado rcmachado rcmachado approved these changes

@rodrigowirth rodrigowirth rodrigowirth approved these changes

@alexantoniomoran alexantoniomoran alexantoniomoran approved these changes

@werberthgomes werberthgomes Awaiting requested review from werberthgomes

@gumaestri gumaestri Awaiting requested review from gumaestri

@eduardocardoso eduardocardoso Awaiting requested review from eduardocardoso

@barbosa barbosa Awaiting requested review from barbosa

Assignees

@umluizlima umluizlima

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umluizlima @rcmachado @rodrigowirth @alexantoniomoran