improve noncombat stat gains with equipment #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move equipRollover after nightcap because if it's done before nightcap, consume can replace the rollover equipment with a mafia pinky ring or with statgain equipment
quarklikeadork
added a commit
to quarklikeadork/autoscend_edits
that referenced
this pull request
Apr 9, 2022
4 tasks
Alium58
reviewed
Apr 22, 2022
| //want to equip best equipment that increases specified stat gains including out of combat | ||
| //should be frequently called by consume actions so try not to lose HP or MP, but will equip anyway if argument alwaysEquip is true | ||
| string maximizerStatement; | ||
| foreach st in increaseThisStat |
There was a problem hiding this comment.
will this skip stats which have been set to false?
There was a problem hiding this comment.
it would not, aggregates written like $stats[] only have true values in them but blocked false values now in case someone uses the function differently,
also added tonic djinn handling
Alium58
previously approved these changes
Apr 24, 2022
There was a problem hiding this comment.
Thanks for the updates! Do you know logic of why tonic djinn is only used on day 2? Seems like a better spot would be at the end of LX_dailyDungeonToken(). Going to approve as is since that isn't something you changed. Up to you if you want to merge or make a change.
|
oops that was a change I made but skipped in the pr, thanks |
Alium58
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use equipment when it can give a free bonus to statgains from consumables and non combat actions
move equipRollover after nightcap because if it's done before nightcap, consume can replace the rollover equipment with a mafia pinky ring or with statgain equipment
How Has This Been Tested?
in run
Checklist: